Bump stylelint from 14.16.1 to 15.10.1 in /backend #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [stylelint](https://github.com/stylelint/stylelint) from 14.16.1 to 15.10.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@14.16.1...15.10.1) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
Terraform plan for management No changes. Your infrastructure matches the configuration.📝 Plan generated in Tests for PRs #647 |
|
Terraform plan for dev No changes. Your infrastructure matches the configuration.❌ Plan not applied in Deploy to Development and Management Environment #237 (Plan has changed) |
|
Stylelint version >15 no longer includes any of the stylistic rules that Refs:
|
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.✅ Plan applied in Deploy to Development and Management Environment #237 |
danswick
reviewed
Sep 26, 2023
Comment on lines
+47
to
+48
| "stylelint-config-standard": "^34.0.0", | ||
| "stylelint-config-standard-scss": "^11.0.0" |
There was a problem hiding this comment.
These two dependencies were both updated to remove stylelint dependencies <15.
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 327eb7e |
danswick
reviewed
Sep 26, 2023
backend/package.json
Outdated
Comment on lines
16
to
17
| "check:stylelint": "npx stylelint '**/*.{css,scss,sass}'", | ||
| "fix:stylelint": "npx stylelint --fix '**/*.{css,scss,sass}'", |
There was a problem hiding this comment.
I think stylelint removed the --ignore-pattern option?
danswick
reviewed
Sep 26, 2023
backend/package.json
Outdated
| "fix:stylelint": "npx stylelint --fix --ignore-pattern uswds static/scss", | ||
| "check:stylelint": "npx stylelint '**/*.{css,scss,sass}'", | ||
| "fix:stylelint": "npx stylelint --fix '**/*.{css,scss,sass}'", | ||
| "check:prettier": "npx prettier --check .", |
There was a problem hiding this comment.
Prettier is currently checking a lot of stuff that we haven't checked in the past (as far as I can tell, anyway). Rendered JSON files, yaml, markdown, etc.
I'm not sure if we want to start checking those things or handle them in other ways.
|
I tried running prettier with To get a diff without all of those noisy changes, see https://github.com/GSA-TTS/FAC/pull/1436/files/ed86906c702399b98c2a596cb0a6fd2cb9c72f53. |
added 2 commits
September 26, 2023 13:42
Stylelint's default rule for media query syntax uses the newer context notation. However, that syntax requires [fairly recent browsers](https://caniuse.com/mdn-css_at-rules_media_or_syntax).
|
@heymatthenry I went ahead and reverted my |
heymatthenry
approved these changes
Sep 26, 2023
|
@danswick Awesome! LGTM. |
heymatthenry
deleted the
dependabot/npm_and_yarn/backend/stylelint-15.10.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps stylelint from 14.16.1 to 15.10.1.
Release notes
Sourced from stylelint's releases.
... (truncated)
Changelog
Sourced from stylelint's changelog.
... (truncated)
Commits
fb8cf3515.10.1eeed72bPrepare release (#7048)8090553Document check of configs in release process (#7047)56a545eSecurity fix forsemvervulnerability (#7043)a42f955Fix rules documentation formedia-query-no-invalid(#7044)e56aa3015.10.0c9e89ebPrepare release (#6974)b8e5317Fixselector-type-caseperformance (#7041)f82a24aFixselector-anb-no-unmatchableperformance (#7042)16110fdRevert removed changelog entry (#7039)Maintainer changes
This version was pushed to npm by mattxwang, a new releaser for stylelint since your current version.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.