Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Page Timeout #1517

Merged
merged 11 commits into from
Aug 3, 2023
Merged

Upload Page Timeout #1517

merged 11 commits into from
Aug 3, 2023

Conversation

jperson1
Copy link
Contributor

Upload Page Timeout (and Some JS Cleaning?)

Issue: #1050

Changes:

  1. Implemented the 30s timeout for XLSX upload. If the frontend doesn't receive anything by then, it aborts the request and lets the user know.
  2. Some minor cleanup of error reporting. All the info_box changes and console.error()'s are in one place, at least.
  3. Moved the submit button below the info_box, so users are better able to see the feedback being presented.

How to test:

  1. Switch to this branch and run normally.
  2. Navigate to an XLSX upload page, like http://localhost:8000/audit/submission-progress/SACIDHERE.
  3. You can try to find an upload that takes longer than 30 seconds, or you can navigate to /backend/static/js/globals.js and change it to a short value, such as 500 for 0.5 seconds.
  4. Upload a .xlsx file, and see a relevant error message both on the page and in the browser console.

Screenshot:

image

@jperson1 jperson1 added bug Something isn't working front end labels Jul 17, 2023
@jperson1 jperson1 added this to the Feature-complete MVP milestone Jul 17, 2023
@jperson1 jperson1 self-assigned this Jul 17, 2023
@jperson1 jperson1 temporarily deployed to dev July 17, 2023 20:30 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to management July 17, 2023 20:30 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Terraform plan for management

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #66

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #66

@jperson1 jperson1 temporarily deployed to management July 27, 2023 18:16 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to dev July 27, 2023 18:16 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to dev July 27, 2023 18:42 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to management July 27, 2023 18:42 — with GitHub Actions Inactive
@jperson1 jperson1 marked this pull request as ready for review July 27, 2023 18:48
@jadudm jadudm removed the javascript label Jul 31, 2023
@jadudm jadudm temporarily deployed to dev August 2, 2023 18:32 — with GitHub Actions Inactive
@jadudm jadudm temporarily deployed to management August 2, 2023 18:32 — with GitHub Actions Inactive
Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jperson1 , this looks good. There's a few changes that feel like they're not strictly about the timeout. I'm going to approve, and you do the merge if you feel good about what is in this PR.

(I'm seeing things like name changes on error handlers, etc., which I'm going to trust you to know to be OK, given that you're living in this space.)

@jperson1 jperson1 temporarily deployed to dev August 3, 2023 21:09 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to management August 3, 2023 21:09 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to management August 3, 2023 21:23 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to dev August 3, 2023 21:23 — with GitHub Actions Inactive
@jperson1 jperson1 merged commit cb8ee38 into main Aug 3, 2023
@jperson1 jperson1 deleted the jp/upload-page-timeout branch August 3, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants