-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload Page Timeout #1517
Upload Page Timeout #1517
Conversation
Terraform plan for management No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #66 |
Terraform plan for dev No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #66 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jperson1 , this looks good. There's a few changes that feel like they're not strictly about the timeout. I'm going to approve, and you do the merge if you feel good about what is in this PR.
(I'm seeing things like name changes on error handlers, etc., which I'm going to trust you to know to be OK, given that you're living in this space.)
Upload Page Timeout (and Some JS Cleaning?)
Issue: #1050
Changes:
info_box
changes andconsole.error()
's are in one place, at least.info_box
, so users are better able to see the feedback being presented.How to test:
/backend/static/js/globals.js
and change it to a short value, such as 500 for 0.5 seconds.Screenshot: