Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error out if we're not on the zeroth instance; use conditional instead #1681

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

tadhg-ohiggins
Copy link
Contributor

Always erroring
Turns out to mean we don't start
The production app

@tadhg-ohiggins tadhg-ohiggins requested review from jadudm and mogul August 2, 2023 22:38
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to dev August 2, 2023 22:38 — with GitHub Actions Inactive
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to management August 2, 2023 22:38 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Terraform plan for management

Plan: 0 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # cloudfoundry_space_users.space_permissions["management"] will be updated in-place
  ~ resource "cloudfoundry_space_users" "space_permissions" {
        id         = "27970728-5de5-c34c-de28-4c98f30a4d5d"
      ~ managers   = [
          + "cfdaac5d-4bb5-4655-98c2-e074374e4347",
            # (3 unchanged elements hidden)
        ]
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #60

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Terraform plan for dev

Plan: 0 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.dev.module.https-proxy.cloudfoundry_app.egress_app will be updated in-place
  ~ resource "cloudfoundry_app" "egress_app" {
        id                              = "a6eb3870-2769-4aa9-a8f2-f1a31939f563"
        name                            = "https-proxy"
      ~ source_code_hash                = "9fcf4a7f6abfc9a220de2b8bb97591ab490a271ac0933b984f606f645319e1a4" -> "9b63bf9766c73480bf1c2385e259b1321988ede71a7b68ebe5c451d9ff6bf1c1"
        # (18 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #60

@mogul mogul merged commit b8d4ead into main Aug 2, 2023
@mogul mogul deleted the tadhg/profile-conditional-fix branch August 2, 2023 22:39
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to dev August 2, 2023 22:58 — with GitHub Actions Inactive
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to management August 2, 2023 22:58 — with GitHub Actions Inactive
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to dev August 2, 2023 22:59 — with GitHub Actions Inactive
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to management August 2, 2023 22:59 — with GitHub Actions Inactive
@mogul mogul mentioned this pull request Aug 2, 2023
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to dev August 2, 2023 23:27 — with GitHub Actions Inactive
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to management August 2, 2023 23:27 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants