Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a null check #1719

Merged
merged 1 commit into from
Aug 4, 2023
Merged

We need a null check #1719

merged 1 commit into from
Aug 4, 2023

Conversation

tadhg-ohiggins
Copy link
Contributor

Omitting null checks:
The gift that keeps on giving.
I should know better.


I didn’t include a null check here first time around because I verified that the function that ultimately uses this one isn’t called anywhere except on a page that has the element in question (and if that weren’t true, we’d want to know)—but the way the JS is actually structured means that getCookie gets loaded and called on every page regardless, so the check is necessary.

…hat doesn't need it, it's still loaded and executed on other pages.
@tadhg-ohiggins tadhg-ohiggins requested a review from a team August 4, 2023 00:39
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to dev August 4, 2023 00:39 — with GitHub Actions Inactive
@tadhg-ohiggins tadhg-ohiggins temporarily deployed to management August 4, 2023 00:39 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Terraform plan for management

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #69

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #69

@tadhg-ohiggins tadhg-ohiggins merged commit 2684bd3 into main Aug 4, 2023
@tadhg-ohiggins tadhg-ohiggins deleted the tadhg/its-always–null-checks branch August 4, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant