-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End-to-end submission through workbook upload #1732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform plan for management No changes. Your infrastructure matches the configuration.
📝 Plan generated in Pull Request Checks #294 |
Terraform plan for dev No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #75 |
LGTM |
jadudm
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Very nice work, y'all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the end-to-end Cypress testing from Epic #1399, moving the submission process through the general info form and uploading the required workbooks.
This will need further work to complete the required parts of submission: PDF upload, remaining workbooks (possibly empty?), and then certification by auditee and auditor.
For the future work, individual Cypress tests can be defined in
backend/cypress/e2e/*.cy.js
. Then, their "happy-path" test behaviors (inside of theit
statement) can be extracted into a file inbackend/cypress/support/*.js
and imported in the original.cy.js
file, but ALSO imported intobackend/cypress/e2e/full-submission.cy.js
and called in the proper sequence.