Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end submission through workbook upload #1732

Merged
merged 8 commits into from
Aug 4, 2023
Merged

Conversation

neilmb
Copy link
Contributor

@neilmb neilmb commented Aug 4, 2023

This continues the end-to-end Cypress testing from Epic #1399, moving the submission process through the general info form and uploading the required workbooks.

This will need further work to complete the required parts of submission: PDF upload, remaining workbooks (possibly empty?), and then certification by auditee and auditor.

For the future work, individual Cypress tests can be defined in backend/cypress/e2e/*.cy.js. Then, their "happy-path" test behaviors (inside of the it statement) can be extracted into a file in backend/cypress/support/*.js and imported in the original .cy.js file, but ALSO imported into backend/cypress/e2e/full-submission.cy.js and called in the proper sequence.

@neilmb neilmb requested review from jperson1 and eazapata23 August 4, 2023 18:56
@neilmb neilmb temporarily deployed to dev August 4, 2023 18:56 — with GitHub Actions Inactive
@neilmb neilmb deployed to management August 4, 2023 18:56 — with GitHub Actions Active
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Terraform plan for management

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

📝 Plan generated in Pull Request Checks #294

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #75

@eazapata23
Copy link
Member

LGTM

Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very nice work, y'all.

@jadudm jadudm merged commit b7f12e5 into main Aug 4, 2023
@jadudm jadudm deleted the nmb/cypres-general-info branch August 4, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants