Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Submission Checklist #1758

Merged
merged 12 commits into from
Aug 10, 2023
Merged

New Submission Checklist #1758

merged 12 commits into from
Aug 10, 2023

Conversation

jperson1
Copy link
Contributor

@jperson1 jperson1 commented Aug 8, 2023

Submission Checklist Updates (First Real Implementation)

Issue: #1560
Figma: Submission checklist

Changes:

  1. The big change is the new submission checklist HTML.
    • The old checklist (submission-progress.html) was moved and renamed to submission-checklist.html.
    • It is in its own subfolder, /audit/templates/audit/submission_checklist, with a few helper components.
    • It's a little long. I chose to use larger if/else blocks to avoid complexity that will make things harder to change in the future.
  2. Some main.scss changes to help bring things closer to Figma in the future. These are utility changes, so only components that make use of the relevant utility are changed. This includes:
    • Making font-[type]-md 18 point, instead of 17.
    • Making font-[type]-lg 36 point, instead of 32.
    • Making the value for success-lighter much lighter (equivalent to 0.1 opacity on a white background), for use as a background color. #56B833 -> #eef8eb

How to test:

  1. Switch to this branch and run normally.
  2. Make a new submission (view an old one), and check out the new checklist.
  3. Play around with submitting things and viewing how the checklist changes. You can also change things in your DB to skip steps.

Screenshots:

image

@jperson1 jperson1 temporarily deployed to dev August 8, 2023 16:03 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to meta August 8, 2023 16:03 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Terraform plan for meta

Plan: 4 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.environments["dev"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../dev/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["preview"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../preview/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["production"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../production/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["staging"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../staging/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

Plan: 4 to add, 0 to change, 0 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #92

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #92

@jperson1 jperson1 temporarily deployed to dev August 8, 2023 16:17 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to meta August 8, 2023 16:17 — with GitHub Actions Inactive
Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadudm jadudm marked this pull request as ready for review August 10, 2023 20:07
Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM.

@jadudm jadudm merged commit d6f9ab8 into main Aug 10, 2023
@jadudm jadudm deleted the jp/submission-checklist-new branch August 10, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants