Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve total_fed_expenditures, type_report_major_program, type_requirement #1786

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

JeanMarie-PM
Copy link
Contributor

No description provided.

@JeanMarie-PM JeanMarie-PM temporarily deployed to dev August 10, 2023 21:09 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to meta August 10, 2023 21:09 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Terraform plan for meta

Plan: 4 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.environments["dev"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../dev/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["preview"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../preview/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["production"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../production/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["staging"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../staging/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

Plan: 4 to add, 0 to change, 0 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #98

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #98

@JeanMarie-PM JeanMarie-PM requested a review from a team August 10, 2023 21:22
@JeanMarie-PM JeanMarie-PM temporarily deployed to dev August 10, 2023 21:30 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to meta August 10, 2023 21:30 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM marked this pull request as ready for review August 11, 2023 18:24
Copy link
Contributor

@danswick danswick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I think an unrelated change snuck into audit-info-form.html

@@ -6,7 +6,7 @@
<div class="usa-navbar bg-primary-darker text-white width-full flex">
<p class="margin-left-2">
<a href="/" class="text-gray-10">My audit submissions</a> »
<a href="{% url 'audit:SubmissionProgress' report_id %}"
<a href="/audit/submission-progress/{{ report_id }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think James has been gradually changing all of these to Django's tagged style so we don't have to update them manually whenever there's a URL change.

@JeanMarie-PM JeanMarie-PM temporarily deployed to dev August 11, 2023 21:44 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to meta August 11, 2023 21:44 — with GitHub Actions Inactive
Copy link
Contributor

@danswick danswick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JeanMarie-PM JeanMarie-PM merged commit cfb4a29 into main Aug 11, 2023
@JeanMarie-PM JeanMarie-PM deleted the jmm/1734 branch August 11, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants