Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmm/1729 sp_framework fields #1798

Merged
merged 10 commits into from
Aug 14, 2023
Merged

Jmm/1729 sp_framework fields #1798

merged 10 commits into from
Aug 14, 2023

Conversation

JeanMarie-PM
Copy link
Contributor

No description provided.

@JeanMarie-PM JeanMarie-PM linked an issue Aug 12, 2023 that may be closed by this pull request
@JeanMarie-PM JeanMarie-PM temporarily deployed to dev August 12, 2023 00:41 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to meta August 12, 2023 00:41 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2023

Terraform plan for meta

Plan: 4 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.environments["dev"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../dev/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["preview"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../preview/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["production"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../production/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["staging"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../staging/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

Plan: 4 to add, 0 to change, 0 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #105

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #105

@JeanMarie-PM JeanMarie-PM temporarily deployed to dev August 12, 2023 00:47 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to meta August 12, 2023 00:47 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to dev August 13, 2023 18:14 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to meta August 13, 2023 18:14 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to dev August 14, 2023 05:35 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to meta August 14, 2023 05:35 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM requested a review from jperson1 August 14, 2023 15:12
backend/static/js/audit-info-form.js Outdated Show resolved Hide resolved
@JeanMarie-PM JeanMarie-PM temporarily deployed to meta August 14, 2023 19:48 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to dev August 14, 2023 19:48 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to dev August 14, 2023 20:08 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM temporarily deployed to meta August 14, 2023 20:08 — with GitHub Actions Inactive
@JeanMarie-PM JeanMarie-PM requested a review from a team August 14, 2023 20:19
@JeanMarie-PM JeanMarie-PM marked this pull request as ready for review August 14, 2023 20:19
@jadudm jadudm temporarily deployed to dev August 14, 2023 21:02 — with GitHub Actions Inactive
@jadudm jadudm temporarily deployed to meta August 14, 2023 21:02 — with GitHub Actions Inactive
Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Again. GH seems to have been out of sync?

@jadudm jadudm dismissed jperson1’s stale review August 14, 2023 21:17

We have a sync problem, it seems. JM resolved this; thank you, JP, for your review!

@jadudm jadudm merged commit c4d96b7 into main Aug 14, 2023
@jadudm jadudm deleted the jmm/1729 branch August 14, 2023 21:17
asteel-gsa pushed a commit that referenced this pull request Aug 15, 2023
* Display the sp fields

* Persist the fields in the DB

* Resolve linting errors

* Handle consitionial rendering - untested

* Fix linting issues

* Fix js to ensure sp_ fields are null when not applicable

* Fix js to actually submit the form

* Make fields optional in forms.py

* Update backend/schemas/source/base/GAAP.libsonnet

---------

Co-authored-by: Matthew Jadud <matthew.jadud@gsa.gov>
asteel-gsa added a commit that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special framework questions on audit information
3 participants