Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Full Submission Fix #1856

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

jperson1
Copy link
Contributor

Cypress Full Submission Fix - Up To Cross-validation

Changes:
All changes are made with full-submission.cy.js in mind. This is the test that runs when attempting to deploy to staging.

  1. Some pre-filled excel files get their own subfolder under /fixtures/test_workbooks. They are not generated by code anywhere, that is a future enhancement.
  2. Workbook uploads through Cypress will actually upload a document. This will ensure there is data in the DB for cross-val to run on.
  3. The audit information form is filled out after uploading all the excel files.
  4. Cross validation is run, and then it's done. The submission is not locked.
  5. Auditee information fiscal period dates are now 01/01/2022 -> 12/31/2022, instead of today -> today, due to form validation that works, woo!
  6. Fixed the cross validation table. It slapped everything in one row, rather than several rows.

@jperson1 jperson1 self-assigned this Aug 16, 2023
@jperson1 jperson1 temporarily deployed to dev August 16, 2023 20:05 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to meta August 16, 2023 20:05 — with GitHub Actions Inactive
@jperson1 jperson1 requested review from eazapata23, phildominguez-gsa and a team August 16, 2023 20:05
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

Terraform plan for meta

Plan: 4 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.environments["dev"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../dev/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["preview"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../preview/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["production"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../production/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["staging"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../staging/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

Plan: 4 to add, 0 to change, 0 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #114

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #114

@eazapata23
Copy link
Member

Looks good i'm able to successfully complete a full submission

@jperson1 jperson1 temporarily deployed to staging August 16, 2023 20:22 — with GitHub Actions Inactive
@jperson1
Copy link
Contributor Author

The workflow for Cypress now passes when pointed at this branch:

https://github.com/GSA-TTS/FAC/actions/runs/5883459366/job/15956217452

@jperson1 jperson1 marked this pull request as ready for review August 16, 2023 20:25
@jperson1 jperson1 temporarily deployed to dev August 17, 2023 13:28 — with GitHub Actions Inactive
@jperson1 jperson1 temporarily deployed to meta August 17, 2023 13:28 — with GitHub Actions Inactive
Copy link
Member

@eazapata23 eazapata23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jperson1 jperson1 merged commit 989f495 into main Aug 17, 2023
@jperson1 jperson1 deleted the jp/cypress-workbooks-and-prevalidation branch August 17, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants