Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock AV scans in fixture tests #1886

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Mock AV scans in fixture tests #1886

merged 2 commits into from
Aug 21, 2023

Conversation

timoballard
Copy link
Contributor

@timoballard timoballard commented Aug 21, 2023

PR checklist: submitters

  • Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
  • List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
  • For extra credit, submit a screen recording like this one.
  • Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
  • Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
  • Do manual testing locally. Our tests are not good enough yet to allow us to skip this step.
  • If Git surgery is necessary at any point, repeat the testing after it’s finished.
  • Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area (such as submission) still works.

PR checklist: reviewers

  • Pull the branch to your local environment and run make docker clean; make docker-first-run && docker compose up; then run docker compose exec web /bin/bash -c "python manage.py test"
  • Manually test out the changes locally (not necessary for this case).
  • Check that the PR has appropriate tests. Look out for changes in HTML/JS/JSON Schema logic that may need to be captured in Python tests even though the logic isn’t in Python.
  • If Git surgery is necessary at any point (such as during a merge party), repeat the testing after it’s finished.

The larger the PR, the stricter we should be about these points.

@timoballard timoballard temporarily deployed to dev August 21, 2023 15:34 — with GitHub Actions Inactive
@timoballard timoballard requested a review from jadudm August 21, 2023 15:34
@timoballard timoballard temporarily deployed to meta August 21, 2023 15:34 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

Terraform plan for meta

Plan: 4 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.environments["dev"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../dev/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["preview"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../preview/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["production"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../production/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["staging"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../staging/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

Plan: 4 to add, 0 to change, 0 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #130

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #130

@timoballard timoballard temporarily deployed to dev August 21, 2023 15:35 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to meta August 21, 2023 15:35 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

File Coverage Missing
All files 89%
api/serializers.py 89% 117-118 123 128
api/test_views.py 99%
api/uei.py 96% 17-18 107-108
api/views.py 97% 160-161 168-169 190 368-369
audit/cog_agency.py 94% 49
audit/cog_over.py 53% 73-116 120-136 144
audit/etl.py 78% 55-56 73-74 107 194-200 214-235 256 271 401-430
audit/excel.py 87% 397 413 419 424 429 451-452 464 665-666 675-681 691 711
audit/forms.py 52% 22-32
audit/models.py 82% 86 155 311 329-330 338 360 417-420 449-450 454 462 471 481 484-490
audit/test_commands.py 87%
audit/test_etl.py 97% 235-250 331-334
audit/test_mixins.py 90% 112-113 117-119 184-185 189-191
audit/test_validators.py 94% 433 437 605-606 844 851 858 865
audit/utils.py 92% 12
audit/validators.py 95% 248-257 282-283 298-299 309 500-509
audit/views.py 36% 80-101 124-125 187-188 231-232 242-253 294-307 310-324 329-342 356-362 367-387 414-418 423-452 492-496 501-521 548-552 557-586 626-630 635-647 650-661 666-678 691-692 770-771 776-825 828-856 859-876 881-884 889 936-956 959-1025
audit/cross_validation/additional_ueis.py 93% 33
audit/cross_validation/check_award_ref_declaration.py 90%
audit/cross_validation/check_award_reference_uniqueness.py 93%
audit/cross_validation/check_findings_count_consistency.py 91%
audit/cross_validation/errors.py 58% 29 60
audit/cross_validation/submission_progress_check.py 88% 88 112-113
audit/cross_validation/tribal_data_sharing_consent.py 86% 20
audit/fixtures/single_audit_checklist.py 86% 155 229-235
audit/management/commands/load_fixtures.py 46% 39-44
cms/views.py 57% 11-16 29-30
dissemination/models.py 99% 685
report_submission/forms.py 90% 9
report_submission/views.py 73% 80 191 195 202-275 278-288
report_submission/templatetags/get_attr.py 76% 8 11-14 18
tools/update_program_data.py 89% 96
users/auth.py 95% 39-40
users/fixtures/user_fixtures.py 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 26d887e

@timoballard timoballard temporarily deployed to dev August 21, 2023 16:21 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to dev August 21, 2023 16:28 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to meta August 21, 2023 16:28 — with GitHub Actions Inactive
@tadhg-ohiggins tadhg-ohiggins merged commit 7ab3738 into main Aug 21, 2023
@tadhg-ohiggins tadhg-ohiggins deleted the tdb/mock-clamav-scan branch August 21, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants