Error Pages

[jperson1]

Error Pages

Issue: #1750
Figma: Link

Changes:

Error pages! New pages 400, 401, 404, 500, and updated page 403.

How to test:

1. Switch to this branch
2. Ensure DEBUG always evaluates to False in your config/settings.py (line ~212). Otherwise, error pages don't display and you'll get a stacktrace.
   • I do this by setting the DJANGO_DEBUG environment variable to False.
3. Run normally, and navigate to some pages that throw errors.
   • For 404, navigate to localhost:8000/anything-you-want-al-long-as-it-doesnt-exist
   • For 403, navigate to an audit that isn't yours, such as: http://localhost:8000/audit/submission-progress/ABUNCHOFNUMBERSNSTUFF
   • The others (400, 401, 500) are tougher to get on purpose. Just to test them out, you can change a view temporarily to return render(request, "401.html") before doing anything else. Navigating to the relevant page will then show the error page.

Screenshots:

400:

401:

403:

404:

500:

PR checklist: submitters

• Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
• List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
• For extra credit, submit a screen recording like this one.
• Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
• Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
• Do manual testing locally. Our tests are not good enough yet to allow us to skip this step. If that’s not applicable for some reason, check this box.
• Verify that no Git surgery was necessary, or, if it was necessary at any point, repeat the testing after it’s finished.
• Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area (such as submission) still works.

PR checklist: reviewers

• Pull the branch to your local environment and run make docker clean; make docker-first-run && docker compose up; then run docker compose exec web /bin/bash -c "python manage.py test"
• Manually test out the changes locally, or check this box to verify that it wasn’t applicable in this case.
• Check that the PR has appropriate tests. Look out for changes in HTML/JS/JSON Schema logic that may need to be captured in Python tests even though the logic isn’t in Python.
• Verify that no Git surgery is necessary at any point (such as during a merge party), or, if it was, repeat the testing after it’s finished.

The larger the PR, the stricter we should be about these points.

[github-actions]

Terraform plan for meta

Plan: 4 to add, 0 to change, 0 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.environments["dev"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../dev/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["preview"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../preview/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["production"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../production/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["staging"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../staging/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

Plan: 4 to add, 0 to change, 0 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #151

[github-actions]

Terraform plan for dev

No changes. Your infrastructure matches the configuration.

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #151

[github-actions]

File	Coverage		Missing
All files	90%	✅
api/serializers.py	89%	❌	121-122 127 132
api/test_views.py	99%	✅
api/uei.py	96%	✅	17-18 107-108
api/views.py	97%	✅	187-188 195-196 217 395-396
audit/cog_agency.py	94%	✅	49
audit/cog_over.py	53%	❌	73-116 120-136 144
audit/etl.py	78%	❌	55-56 73-74 107 194-200 214-235 256 271 401-430
audit/excel.py	87%	❌	397 413 419 424 429 451-452 464 665-666 675-681 691 711
audit/forms.py	56%	❌	22-29
audit/models.py	82%	❌	86 155 311 329-330 338 360 417-420 449-450 454 462 471 481 484-490
audit/test_commands.py	87%	❌
audit/test_etl.py	97%	✅	235-250 331-334
audit/test_mixins.py	90%	✅	112-113 117-119 184-185 189-191
audit/test_validators.py	95%	✅	434 438 606-607 846 853 860 867
audit/utils.py	92%	✅	12
audit/validators.py	96%	✅	253-254 282-283 298-299 309 500-509
audit/views.py	38%	❌	82-103 126-127 189-190 233-234 244-255 296-309 312-326 331-344 358-364 369-389 416-420 425-454 494-498 503-523 550-554 559-588 628-632 637-649 652-663 668-680 693-694 772-773 778-827 830-867 870-887
audit/cross_validation/additional_ueis.py	93%	✅	33
audit/cross_validation/check_award_ref_declaration.py	90%	✅
audit/cross_validation/check_award_reference_uniqueness.py	93%	✅
audit/cross_validation/check_findings_count_consistency.py	91%	✅
audit/cross_validation/check_ref_number_in_cap.py	90%	✅
audit/cross_validation/check_ref_number_in_findings_text.py	90%	✅
audit/cross_validation/errors.py	78%	❌	30 61
audit/cross_validation/submission_progress_check.py	88%	❌	87 112-113
audit/cross_validation/tribal_data_sharing_consent.py	86%	❌	20
audit/fixtures/single_audit_checklist.py	86%	❌	155 229-235
audit/management/commands/load_fixtures.py	46%	❌	39-44
audit/viewlib/upload_report_view.py	31%	❌	31-34 43 90-110 113-178
cms/views.py	57%	❌	11-16 29-30
config/urls.py	71%	❌	87
dissemination/models.py	99%	✅	685
report_submission/forms.py	90%	✅	9
report_submission/views.py	72%	❌	82 191-193 195 201-308 311-321
report_submission/templatetags/get_attr.py	76%	❌	8 11-14 18
tools/update_program_data.py	89%	❌	96
users/auth.py	95%	✅	39-40
users/fixtures/user_fixtures.py	91%	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 38054eb