-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Login.gov sandbox configurations by environment #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform plan for meta Plan: 4 to add, 0 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# module.environments["dev"].local_file.cf_org will be created
+ resource "local_file" "cf_org" {
+ content = <<-EOT
cf_org_name = "gsa-tts-oros-fac"
EOT
+ content_base64sha256 = (known after apply)
+ content_base64sha512 = (known after apply)
+ content_md5 = (known after apply)
+ content_sha1 = (known after apply)
+ content_sha256 = (known after apply)
+ content_sha512 = (known after apply)
+ directory_permission = "0777"
+ file_permission = "0644"
+ filename = "./../dev/orgname.auto.tfvars"
+ id = (known after apply)
}
# module.environments["preview"].local_file.cf_org will be created
+ resource "local_file" "cf_org" {
+ content = <<-EOT
cf_org_name = "gsa-tts-oros-fac"
EOT
+ content_base64sha256 = (known after apply)
+ content_base64sha512 = (known after apply)
+ content_md5 = (known after apply)
+ content_sha1 = (known after apply)
+ content_sha256 = (known after apply)
+ content_sha512 = (known after apply)
+ directory_permission = "0777"
+ file_permission = "0644"
+ filename = "./../preview/orgname.auto.tfvars"
+ id = (known after apply)
}
# module.environments["production"].local_file.cf_org will be created
+ resource "local_file" "cf_org" {
+ content = <<-EOT
cf_org_name = "gsa-tts-oros-fac"
EOT
+ content_base64sha256 = (known after apply)
+ content_base64sha512 = (known after apply)
+ content_md5 = (known after apply)
+ content_sha1 = (known after apply)
+ content_sha256 = (known after apply)
+ content_sha512 = (known after apply)
+ directory_permission = "0777"
+ file_permission = "0644"
+ filename = "./../production/orgname.auto.tfvars"
+ id = (known after apply)
}
# module.environments["staging"].local_file.cf_org will be created
+ resource "local_file" "cf_org" {
+ content = <<-EOT
cf_org_name = "gsa-tts-oros-fac"
EOT
+ content_base64sha256 = (known after apply)
+ content_base64sha512 = (known after apply)
+ content_md5 = (known after apply)
+ content_sha1 = (known after apply)
+ content_sha256 = (known after apply)
+ content_sha512 = (known after apply)
+ directory_permission = "0777"
+ file_permission = "0644"
+ filename = "./../staging/orgname.auto.tfvars"
+ id = (known after apply)
}
Plan: 4 to add, 0 to change, 0 to destroy. ✅ Plan applied in Deploy to Development and Management Environment #173 |
Terraform plan for dev No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #173 |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2c8c5a2 |
timoballard
requested review from
asteel-gsa,
danswick,
jadudm,
JeanMarie-PM and
tadhg-ohiggins
September 5, 2023 20:56
LGTM |
asteel-gsa
previously approved these changes
Sep 5, 2023
The value will be stored in VCAP_SERVICES, so, will need to use the secret() method to obtain it.
asteel-gsa
reviewed
Sep 5, 2023
asteel-gsa
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2020
Makes the Login.gov client ID configurable so that we can target a different Login.gov application configuration for each environment (until now, we've had a single client application for all environments).
Github environment secrets have been updated accordingly.
When running locally, you should update your
.env
file to include the updated values from our shared dev keys workbookPR checklist: submitters
main
into your branch shortly before creating the PR. (You should also be mergingmain
into your branch regularly during development.)PR checklist: reviewers
make docker clean; make docker-first-run && docker compose up
; then rundocker compose exec web /bin/bash -c "python manage.py test"
The larger the PR, the stricter we should be about these points.