Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding myself to the list of team members as per the checklist (#2277). #2313

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

purvinptl
Copy link
Contributor

@purvinptl purvinptl commented Sep 29, 2023

Adding myself to the list of team members as per checklist (#2277).

@purvinptl purvinptl requested a review from a team as a code owner September 29, 2023 18:47
@purvinptl purvinptl temporarily deployed to dev September 29, 2023 18:48 — with GitHub Actions Inactive
@purvinptl purvinptl temporarily deployed to meta September 29, 2023 18:48 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.dev.module.database.cloudfoundry_service_instance.rds,
  on /tmp/terraform-data-dir/modules/dev.database/database/main.tf line 14, in resource "cloudfoundry_service_instance" "rds":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 2 more similar warnings elsewhere)

❌ Error applying plan in Deploy to Development and Management Environment #251

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Terraform plan for meta

Plan: 0 to add, 4 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.environments["dev"].cloudfoundry_space_users.space_permissions will be updated in-place
  ~ resource "cloudfoundry_space_users" "space_permissions" {
      ~ developers = [
          + "purvin.patel@gsa.gov",
            # (13 unchanged elements hidden)
        ]
        id         = "06525ba3-19c2-451b-96e9-ea4a9134e8b9"
        # (4 unchanged attributes hidden)
    }

  # module.environments["preview"].cloudfoundry_space_users.space_permissions will be updated in-place
  ~ resource "cloudfoundry_space_users" "space_permissions" {
      ~ developers = [
          + "purvin.patel@gsa.gov",
            # (13 unchanged elements hidden)
        ]
        id         = "c21cdcb1-b760-4f3e-968d-469819b448e9"
        # (4 unchanged attributes hidden)
    }

  # module.environments["production"].cloudfoundry_space_users.space_permissions will be updated in-place
  ~ resource "cloudfoundry_space_users" "space_permissions" {
      ~ developers = [
          + "purvin.patel@gsa.gov",
            # (13 unchanged elements hidden)
        ]
        id         = "5593dba8-7023-49a5-bdbe-e809fe23edf9"
        # (4 unchanged attributes hidden)
    }

  # module.environments["staging"].cloudfoundry_space_users.space_permissions will be updated in-place
  ~ resource "cloudfoundry_space_users" "space_permissions" {
      ~ developers = [
          + "purvin.patel@gsa.gov",
            # (13 unchanged elements hidden)
        ]
        id         = "7bbe587a-e8ee-4e8c-b32f-86d0b0f1b807"
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 4 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.s3-backups.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/s3-backups/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

❌ Error applying plan in Deploy to Development and Management Environment #251

@github-actions
Copy link
Contributor

File Coverage Missing
All files 89%
api/serializers.py 90% 125-126 131 136
api/test_views.py 96% 105
api/uei.py 96% 17-18 107-108
api/views.py 97% 196-197 204-205 226 362-363
audit/excel.py 87% 402 418 424 429 434 456-457 469 670-671 680-686 696 716
audit/forms.py 56% 22-29
audit/intake_to_dissemination.py 92% 70-71 200-206 256
audit/models.py 87% 185 218 389 407-408 416 438 514-515 519 527 536 540 546 549-555
audit/test_commands.py 87%
audit/test_mixins.py 90% 112-113 117-119 184-185 189-191
audit/test_validators.py 95% 436 440 608-609 848 855 862 869
audit/utils.py 76% 13 21 38
audit/validators.py 96% 298-299 314-315 525-534
audit/views.py 42% 86-107 130-131 205-206 251-252 263-264 266-270 317-330 333-347 352-365 382-388 393-413 440-444 449-478 521-525 530-550 577-581 586-615 658-662 667-679 682-692 697-709 732-733 738-787 790-830 833-850
audit/cross_validation/additional_ueis.py 93% 33
audit/cross_validation/check_award_ref_declaration.py 90%
audit/cross_validation/check_award_reference_uniqueness.py 93%
audit/cross_validation/check_certifying_contacts.py 87%
audit/cross_validation/check_findings_count_consistency.py 91%
audit/cross_validation/check_ref_number_in_cap.py 90%
audit/cross_validation/check_ref_number_in_findings_text.py 90%
audit/cross_validation/errors.py 78% 30 65
audit/cross_validation/naming.py 68% 178-182
audit/cross_validation/submission_progress_check.py 85% 64 79-82
audit/cross_validation/tribal_data_sharing_consent.py 86% 20
audit/cross_validation/validate_general_information.py 93% 28-29
audit/fixtures/single_audit_checklist.py 79% 156 232-241
audit/management/commands/load_fixtures.py 46% 39-45
audit/viewlib/submission_progress_view.py 96% 158-159
audit/viewlib/upload_report_view.py 30% 32-35 44 91-115 118-186
cms/views.py 57% 11-16 29-30
config/urls.py 71% 87
djangooidc/backends.py 78% 32 57-63
djangooidc/exceptions.py 66% 19 21 23 28
djangooidc/oidc.py 16% 32-35 45-51 64-70 92-149 153-199 203-226 230-275 280-281 286
djangooidc/views.py 80% 22 43 114
djangooidc/tests/common.py 96%
report_submission/forms.py 92% 35
report_submission/views.py 76% 83 215-216 218 240-241 260-261 287-396 399-409
report_submission/templatetags/get_attr.py 76% 8 11-14 18
support/admin.py 49% 9-10 13 34 37 74 77 82 89-95 98-100 103-104 107-108
support/cog_over.py 90% 30-33 86 93 145
support/signals.py 66% 23-24 29-30
support/test_cog_over.py 98% 134-135 224
tools/update_program_data.py 89% 96
users/auth.py 95% 39-40
users/fixtures/user_fixtures.py 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 65c81c4

Copy link
Contributor

@danswick danswick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@purvinptl purvinptl added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 4b6edd8 Oct 2, 2023
14 checks passed
@purvinptl purvinptl deleted the add-purvin-to-developers branch October 2, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants