Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-release instructions from prod deploy notes #2328

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

danswick
Copy link
Contributor

PR checklist: submitters

  • Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
  • List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
  • For extra credit, submit a screen recording like this one.
  • Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
  • Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
  • Do manual testing locally. Our tests are not good enough yet to allow us to skip this step. If that’s not applicable for some reason, check this box.
  • Verify that no Git surgery was necessary, or, if it was necessary at any point, repeat the testing after it’s finished.
  • Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area (such as submission) still works.

PR checklist: reviewers

  • Pull the branch to your local environment and run make docker-clean; make docker-first-run && docker compose up; then run docker compose exec web /bin/bash -c "python manage.py test"
  • Manually test out the changes locally, or check this box to verify that it wasn’t applicable in this case.
  • Check that the PR has appropriate tests. Look out for changes in HTML/JS/JSON Schema logic that may need to be captured in Python tests even though the logic isn’t in Python.
  • Verify that no Git surgery is necessary at any point (such as during a merge party), or, if it was, repeat the testing after it’s finished.

The larger the PR, the stricter we should be about these points.

Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jadudm jadudm added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit d6f60e4 Oct 2, 2023
@jadudm jadudm deleted the danswick-patch-1 branch October 2, 2023 20:55
jperson1 added a commit that referenced this pull request Oct 3, 2023
* Remove pre-release instructions from prod deploy notes (#2328)

* Resume mocking SAM.gov call (#2360)

We meant to mock this and when we changed to using requests.session
we missed updating the mock call in api/test_views.py.
This wasn't detected because the actual call to SAM.gov would
work—until this week, when the larger volume of SAM.gov API calls
from actual users as well as our tests pushed us past the rate limit.

Co-authored-by: Tadhg O'Higgins <2626258+tadhg-ohiggins@users.noreply.github.com>

* Tribal - sign out/in as auditee, then as auditor

* Cypress - New regex for report_ids

* Oops, committed a local JWT.

* Change tribal audit to private and not in API

---------

Co-authored-by: Dan Swick <daniel.swick@gsa.gov>
Co-authored-by: Tadhg O'Higgins <2626258+tadhg-ohiggins@users.noreply.github.com>
Co-authored-by: Edward Zapata <edward.zapata@gsa.gov>
github-merge-queue bot pushed a commit that referenced this pull request Oct 3, 2023
* Tribal audit consent form, first pass

* What is code without linting?

* Rename files/classes. Update to match Figma.

* no-late-changes id change.

* Djlint autoformat tribal data release

* Title, not date.

* Name/title side by side. Title moved out of grey box

* Fix grey box boundary. Underline grey box title

* We out here, linting python files

* Validate against schema on upload. Copy updates

* Checklist tribal data release description

* add function for tribal audit form+add to full sub

* tribal data consent cross-val

* Grey box encompasses all questions

* Remove-old-wkbks-edit tri-audit-form+gen-info.js

* tribal data consent cross-val (#2283)

* add two functions for tribal audi public & private

* Submission Progress Check - Tribal Data Release (#2310)

* Submission progress check - tribal data release

* Edit link for tribal data release.

* Tribal release above validation

* Don't err if no auditee certifier is found.

* remove is_public from audit model (#2319)

* Cypress - New Report ID Format and Tribal Fix (#2366)

* Remove pre-release instructions from prod deploy notes (#2328)

* Resume mocking SAM.gov call (#2360)

We meant to mock this and when we changed to using requests.session
we missed updating the mock call in api/test_views.py.
This wasn't detected because the actual call to SAM.gov would
work—until this week, when the larger volume of SAM.gov API calls
from actual users as well as our tests pushed us past the rate limit.

Co-authored-by: Tadhg O'Higgins <2626258+tadhg-ohiggins@users.noreply.github.com>

* Tribal - sign out/in as auditee, then as auditor

* Cypress - New regex for report_ids

* Oops, committed a local JWT.

* Change tribal audit to private and not in API

---------

Co-authored-by: Dan Swick <daniel.swick@gsa.gov>
Co-authored-by: Tadhg O'Higgins <2626258+tadhg-ohiggins@users.noreply.github.com>
Co-authored-by: Edward Zapata <edward.zapata@gsa.gov>

---------

Co-authored-by: Edward Zapata <edward.zapata@gsa.gov>
Co-authored-by: danswick <daniel.swick@gsa.gov>
Co-authored-by: Tadhg O'Higgins <2626258+tadhg-ohiggins@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants