Remove SingleAuditChecklist._general_info_get()

[tadhg-ohiggins]

Methods can go stale.
We should remove those than have.
Even one-by-one.

---

We don't use this method anywhere that I can find.

No change is expected to the app; if the tests pass, this should be fine.

---

PR checklist: submitters

• Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
• List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
• For extra credit, submit a screen recording like this one.
• Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
• Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
• Do manual testing locally. Our tests are not good enough yet to allow us to skip this step. If that’s not applicable for some reason, check this box.
• Verify that no Git surgery was necessary, or, if it was necessary at any point, repeat the testing after it’s finished.
• Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area (such as submission) still works.

PR checklist: reviewers

• Pull the branch to your local environment and run make docker-clean; make docker-first-run && docker compose up; then run docker compose exec web /bin/bash -c "python manage.py test"
• Manually test out the changes locally, or check this box to verify that it wasn’t applicable in this case.
• Check that the PR has appropriate tests. Look out for changes in HTML/JS/JSON Schema logic that may need to be captured in Python tests even though the logic isn’t in Python.
• Verify that no Git surgery is necessary at any point (such as during a merge party), or, if it was, repeat the testing after it’s finished.

The larger the PR, the stricter we should be about these points.

[github-actions]

Terraform plan for meta

No changes. Your infrastructure matches the configuration.

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.s3-backups.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/s3-backups/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

✅ Plan applied in Deploy to Development and Management Environment #274

[github-actions]

Terraform plan for dev

Plan: 0 to add, 2 to change, 0 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.dev.cloudfoundry_app.postgrest will be updated in-place
  ~ resource "cloudfoundry_app" "postgrest" {
      ~ docker_image                    = "ghcr.io/gsa-tts/fac/postgrest@sha256:5cb1228f3d1fc6f3d0151a99180d11b38488c9dd7a2eafd95e9e309d3c2fd9e8" -> "ghcr.io/gsa-tts/fac/postgrest@sha256:ded2f8ecea6853f73af1c679cdc6f9b8564978b9a028695bcce001b0a7f7fe3a"
        id                              = "5de6f04c-52e0-400f-961a-16243b1c7c9a"
        name                            = "postgrest"
        # (15 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.dev.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
  ~ resource "cloudfoundry_app" "clamav_api" {
      ~ docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:8b88cea585056d4a67026a0fc5db8ba802a494ffae2a6959ddaceeb59e055a9b" -> "ghcr.io/gsa-tts/fac/clamav@sha256:080f8d91a5abe5e9069aac951bd02173394833bf763b2ed03eb31420f5c55db8"
        id                              = "779bbc51-f78a-4186-90eb-5acb68d7d746"
        name                            = "fac-av-dev"
        # (15 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.dev.module.database.cloudfoundry_service_instance.rds,
  on /tmp/terraform-data-dir/modules/dev.database/database/main.tf line 14, in resource "cloudfoundry_service_instance" "rds":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 2 more similar warnings elsewhere)

✅ Plan applied in Deploy to Development and Management Environment #274

[github-actions]

File	Coverage		Missing
All files	88%	❌
api/serializers.py	90%	✅	125-126 131 136
api/test_views.py	96%	✅	105
api/uei.py	87%	❌	17-18 87 119-120 164 168-169
api/views.py	97%	✅	196-197 204-205 226 362-363
audit/excel.py	85%	❌	52 420 436 442 447 452 474-475 487 564 566 568 570 572 729-730 738-744 762-763 773 795
audit/forms.py	47%	❌	22-29 142-149
audit/intake_to_dissemination.py	92%	✅	67-68 197-203 253
audit/models.py	86%	❌	57 59 64 66 213 246 417 435-436 444 466 542-543 547 555 564 570
audit/test_commands.py	87%	❌
audit/test_mixins.py	90%	✅	112-113 117-119 184-185 189-191
audit/test_validators.py	95%	✅	436 440 608-609 848 855 862 869
audit/utils.py	76%	❌	13 21 38
audit/validators.py	96%	✅	287-288 303-304 514-523
audit/views.py	42%	❌	87-108 131-132 206-207 252-253 264-265 267-271 318-331 334-348 353-366 383-389 394-414 441-445 450-479 522-526 531-551 578-582 587-616 659-663 668-680 683-693 698-710 737-738 743-792 795-835 838-855
audit/cross_validation/additional_ueis.py	93%	✅	33
audit/cross_validation/check_award_ref_declaration.py	90%	✅
audit/cross_validation/check_award_reference_uniqueness.py	93%	✅
audit/cross_validation/check_certifying_contacts.py	87%	❌
audit/cross_validation/check_findings_count_consistency.py	91%	✅
audit/cross_validation/check_ref_number_in_cap.py	90%	✅
audit/cross_validation/check_ref_number_in_findings_text.py	90%	✅
audit/cross_validation/errors.py	78%	❌	30 69
audit/cross_validation/naming.py	68%	❌	178-182
audit/cross_validation/submission_progress_check.py	85%	❌	62 77-80
audit/cross_validation/tribal_data_sharing_consent.py	81%	❌	33 36 40
audit/cross_validation/validate_general_information.py	93%	✅	28-29
audit/fixtures/single_audit_checklist.py	79%	❌	156 232-241
audit/management/commands/load_fixtures.py	46%	❌	39-45
audit/viewlib/submission_progress_view.py	89%	❌	111 171-172
audit/viewlib/tribal_data_consent.py	34%	❌	23-41 44-79
audit/viewlib/upload_report_view.py	26%	❌	32-35 44 91-115 118-168 176-207
cms/views.py	57%	❌	11-16 29-30
config/urls.py	71%	❌	87
dissemination/migrations/0002_general_fac_accepted_date.py	47%	❌	10-12
djangooidc/backends.py	78%	❌	32 57-63
djangooidc/exceptions.py	66%	❌	19 21 23 28
djangooidc/oidc.py	16%	❌	32-35 45-51 64-70 92-149 153-199 203-226 230-275 280-281 286
djangooidc/views.py	80%	❌	22 43 114
djangooidc/tests/common.py	96%	✅
report_submission/forms.py	92%	✅	35
report_submission/views.py	76%	❌	83 215-216 218 240-241 260-261 287-396 399-409
report_submission/templatetags/get_attr.py	76%	❌	8 11-14 18
support/admin.py	49%	❌	9-10 13 34 37 74 77 82 89-95 98-100 103-104 107-108
support/cog_over.py	90%	✅	30-33 86 93 145
support/signals.py	66%	❌	23-24 31-32
support/test_cog_over.py	98%	✅	134-135 224
support/management/commands/seed_cog_baseline.py	98%	✅	20-21
tools/update_program_data.py	89%	❌	96
users/auth.py	95%	✅	40-41
users/fixtures/user_fixtures.py	91%	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 9d1b4f1

[jadudm]

LGTM. This was my favorite method, BTW.