-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding contact_title & is_aicpa_audit_guide_included(DUP_REPORTS) to API Response #2497
Conversation
Terraform plan for dev Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.dev.cloudfoundry_app.postgrest will be updated in-place
~ resource "cloudfoundry_app" "postgrest" {
~ environment = (sensitive value)
id = "5de6f04c-52e0-400f-961a-16243b1c7c9a"
~ id_bg = "************************************" -> (known after apply)
name = "postgrest"
# (14 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Warning: Argument is deprecated
with module.dev.module.database.cloudfoundry_service_instance.rds,
on /tmp/terraform-data-dir/modules/dev.database/database/main.tf line 14, in resource "cloudfoundry_service_instance" "rds":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 2 more similar warnings elsewhere) ✅ Plan applied in Deploy to Development and Management Environment #285 |
Terraform plan for meta No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #285 |
Minimum allowed coverage is Generated by 🐒 cobertura-action against b4581a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm through local testing that the new fields are included in the API responses for /general
and /secondary_auditors
.
backend/docker-compose.yml
Outdated
dockerfile: "./${DOCKERFILE:-Dockerfile}" | ||
dockerfile: "./${DOCKERFILE:-Apple_M1_Dockerfile}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may not want to commit this bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, my fault I missed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed changes removing Apple_M1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR closes #2466 & #2467
This branch includes:
How to Test?
PR checklist: submitters
main
into your branch shortly before creating the PR. (You should also be mergingmain
into your branch regularly during development.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up
; then rundocker compose exec web /bin/bash -c "python manage.py test"
The larger the PR, the stricter we should be about these points.