Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-08-29 | MAIN --> PROD | DEV (377d210) --> STAGING #4241

Merged
merged 5 commits into from
Aug 29, 2024
Merged

2024-08-29 | MAIN --> PROD | DEV (377d210) --> STAGING #4241

merged 5 commits into from
Aug 29, 2024

Conversation

jadudm
Copy link
Contributor

@jadudm jadudm commented Aug 29, 2024

This is an auto-generated pull request to merge main into prod for a staging release on 2024-08-29 with the last commit being merged as 377d210

anagradova and others added 5 commits August 28, 2024 15:42
* added gsa email to config.tf for cloud.gov

* Update config.tf
Sometimes the full-submission tests fail on this line - it seems that the datepicker component does not always respond to .click(), and causes a timeout when the next step attempts to select today's date.

To my understanding it seems `.trigger('click')` is another approach that fares better in cases where `.click()` might fail. I have tested this many times and have yet for Cypress to break on my end with this new line.
* Increase storage by 5x

Per cloud.gov, we are running out of space in the rds in production.
This should *hopefully* sort that out and future proof it.

* set to 75 to match manual scale
@jadudm jadudm added autogenerated Automated pull request creation automerge Used for automated deployments labels Aug 29, 2024
@jadudm jadudm requested a review from a team as a code owner August 29, 2024 10:33
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Terraform plan for staging

Plan: 1 to add, 1 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.staging.cloudfoundry_app.postgrest will be updated in-place
!~  resource "cloudfoundry_app" "postgrest" {
!~      environment                     = (sensitive value)
        id                              = "db50e549-24c7-4dcf-b30e-e9dee3512be8"
!~      id_bg                           = "************************************" -> (known after apply)
        name                            = "postgrest"
#        (16 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

  # module.staging.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2024-08-28T11:12:44Z" -> (known after apply)
        }
    }

Plan: 1 to add, 1 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.staging-backups-bucket.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/staging-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

✅ Plan applied in Deploy to Staging Environment #261

Copy link
Contributor

Terraform plan for production

Plan: 1 to add, 4 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.production.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:8119bc9c23555b7331108f0cf918cabb3303c7b44eb382aadc7a352222eb532c" -> "ghcr.io/gsa-tts/fac/clamav@sha256:7022b7e1822e8efb451c9cc35b4488c42aca306705654980f5a55c5ff62755b3"
        id                              = "5d0afa4f-527b-472a-8671-79a60335417f"
        name                            = "fac-av-production"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

  # module.production.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2024-08-14T17:32:02Z" -> (known after apply)
        }
    }

  # module.production.module.database.cloudfoundry_service_instance.rds will be updated in-place
!~  resource "cloudfoundry_service_instance" "rds" {
        id                             = "258ac781-7f34-465f-b24a-b04ec258f7db"
!~      json_params                    = jsonencode(
!~          {
!~              storage = 50 -> 75
            }
        )
        name                           = "fac-db"
        tags                           = [
            "rds",
        ]
#        (4 unchanged attributes hidden)
    }

  # module.production.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:8119bc9c23555b7331108f0cf918cabb3303c7b44eb382aadc7a352222eb532c" -> "ghcr.io/gsa-tts/fac/clamav@sha256:7022b7e1822e8efb451c9cc35b4488c42aca306705654980f5a55c5ff62755b3"
        id                              = "6b0ce685-a80c-4feb-9ed6-49c6427efdb8"
        name                            = "fac-av-production-fs"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

  # module.production.module.snapshot-database.cloudfoundry_service_instance.rds will be updated in-place
!~  resource "cloudfoundry_service_instance" "rds" {
        id                             = "e026cae8-7564-4886-9317-f84dc4a5b339"
!~      json_params                    = jsonencode(
!~          {
!~              storage = 50 -> 75
            }
        )
        name                           = "fac-snapshot-db"
        tags                           = [
            "rds",
        ]
#        (4 unchanged attributes hidden)
    }

Plan: 1 to add, 4 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #3563

Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18247 16646 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 377d210 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenerated Automated pull request creation automerge Used for automated deployments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants