Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-08-30 | MAIN --> PROD | DEV (dffbf33) --> STAGING #4244

Merged
merged 3 commits into from
Aug 30, 2024
Merged

2024-08-30 | MAIN --> PROD | DEV (dffbf33) --> STAGING #4244

merged 3 commits into from
Aug 30, 2024

Conversation

jadudm
Copy link
Contributor

@jadudm jadudm commented Aug 30, 2024

This is an auto-generated pull request to merge main into prod for a staging release on 2024-08-30 with the last commit being merged as dffbf33

phildominguez-gsa and others added 3 commits August 29, 2024 13:12
* Removing redundant validation

* Lint

* Adding explicit else

* Lint
* Bump esbuild from 0.23.0 to 0.23.1 in /backend

Bumps [esbuild](https://github.com/evanw/esbuild) from 0.23.0 to 0.23.1.
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.23.0...v0.23.1)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump @eslint/js from 9.9.0 to 9.9.1 in /backend

Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.9.0 to 9.9.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/commits/v9.9.1/packages/js)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump eslint from 9.9.0 to 9.9.1 in /backend

Bumps [eslint](https://github.com/eslint/eslint) from 9.9.0 to 9.9.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.9.0...v9.9.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump micromatch in /backend in the npm_and_yarn group

Bumps the npm_and_yarn group in /backend with 1 update: [micromatch](https://github.com/micromatch/micromatch).


Updates `micromatch` from 4.0.7 to 4.0.8
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.7...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump cypress from 13.13.2 to 13.14.0 in /backend

Bumps [cypress](https://github.com/cypress-io/cypress) from 13.13.2 to 13.14.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md)
- [Commits](cypress-io/cypress@v13.13.2...v13.14.0)

---
updated-dependencies:
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Regenerate package-lock

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jadudm jadudm added autogenerated Automated pull request creation automerge Used for automated deployments labels Aug 30, 2024
Copy link
Contributor

Terraform plan for production

Plan: 1 to add, 4 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.production.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:8119bc9c23555b7331108f0cf918cabb3303c7b44eb382aadc7a352222eb532c" -> "ghcr.io/gsa-tts/fac/clamav@sha256:7022b7e1822e8efb451c9cc35b4488c42aca306705654980f5a55c5ff62755b3"
        id                              = "5d0afa4f-527b-472a-8671-79a60335417f"
        name                            = "fac-av-production"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

  # module.production.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2024-08-14T17:32:02Z" -> (known after apply)
        }
    }

  # module.production.module.database.cloudfoundry_service_instance.rds will be updated in-place
!~  resource "cloudfoundry_service_instance" "rds" {
        id                             = "258ac781-7f34-465f-b24a-b04ec258f7db"
!~      json_params                    = jsonencode(
!~          {
!~              storage = 50 -> 75
            }
        )
        name                           = "fac-db"
        tags                           = [
            "rds",
        ]
#        (4 unchanged attributes hidden)
    }

  # module.production.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:8119bc9c23555b7331108f0cf918cabb3303c7b44eb382aadc7a352222eb532c" -> "ghcr.io/gsa-tts/fac/clamav@sha256:7022b7e1822e8efb451c9cc35b4488c42aca306705654980f5a55c5ff62755b3"
        id                              = "6b0ce685-a80c-4feb-9ed6-49c6427efdb8"
        name                            = "fac-av-production-fs"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

  # module.production.module.snapshot-database.cloudfoundry_service_instance.rds will be updated in-place
!~  resource "cloudfoundry_service_instance" "rds" {
        id                             = "e026cae8-7564-4886-9317-f84dc4a5b339"
!~      json_params                    = jsonencode(
!~          {
!~              storage = 50 -> 75
            }
        )
        name                           = "fac-snapshot-db"
        tags                           = [
            "rds",
        ]
#        (4 unchanged attributes hidden)
    }

Plan: 1 to add, 4 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #3580

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Terraform plan for staging

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.staging.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2024-08-29T11:10:14Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.staging-backups-bucket.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/staging-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

✅ Plan applied in Deploy to Staging Environment #262

Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18243 16643 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: dffbf33 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenerated Automated pull request creation automerge Used for automated deployments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants