4385 remove finding idyn uniqueness validation #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.✅ Plan applied in Deploy to Development and Management Environment #847 |
|
Terraform plan for dev Plan: 1 to add, 4 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.dev.cloudfoundry_app.postgrest will be updated in-place
!~ resource "cloudfoundry_app" "postgrest" {
id = "5de6f04c-52e0-400f-961a-16243b1c7c9a"
!~ memory = 512 -> 1024
name = "postgrest"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.dev.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~ resource "cloudfoundry_app" "clamav_api" {
id = "779bbc51-f78a-4186-90eb-5acb68d7d746"
!~ memory = 2048 -> 3072
name = "fac-av-dev"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2024-10-17T21:07:03Z" -> (known after apply)
}
}
# module.dev.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place
!~ resource "cloudfoundry_app" "clamav_api" {
id = "65c83416-4126-4785-99c2-5e1adb810422"
!~ memory = 2048 -> 3072
name = "fac-av-dev-fs"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.dev.module.newrelic.newrelic_one_dashboard.log_review_dashboard will be updated in-place
!~ resource "newrelic_one_dashboard" "log_review_dashboard" {
id = "MzkxOTA3NnxWSVp8REFTSEJPQVJEfGRhOjYzNjMwMjQ"
name = "FAC Log Review (dev)"
# (4 unchanged attributes hidden)
!~ page {
name = "FAC Log Review"
# (2 unchanged attributes hidden)
- widget_billboard {
- column = 9 -> null
- facet_show_other_series = false -> null
- height = 3 -> null
- id = "295726302" -> null
- ignore_time_range = false -> null
- legend_enabled = true -> null
- row = 8 -> null
- title = "dev Table Check Count - Pass" -> null
- width = 3 -> null
- y_axis_left_max = 0 -> null
- y_axis_left_min = 0 -> null
# (3 unchanged attributes hidden)
- nrql_query {
- account_id = 3919076 -> null
- query = "SELECT count(*) FROM Log WHERE `tags.space_name` = 'dev' AND allColumnSearch('CHECKTABLESPASS', insensitive: true) SINCE 7 days ago" -> null
}
}
- widget_billboard {
- column = 9 -> null
- facet_show_other_series = false -> null
- height = 3 -> null
- id = "295726303" -> null
- ignore_time_range = false -> null
- legend_enabled = true -> null
- row = 9 -> null
- title = "dev Table Check Count - Fail" -> null
- width = 3 -> null
- y_axis_left_max = 0 -> null
- y_axis_left_min = 0 -> null
# (3 unchanged attributes hidden)
- nrql_query {
- account_id = 3919076 -> null
- query = "SELECT count(*) FROM Log WHERE `tags.space_name` = 'dev' AND allColumnSearch('DBMISSINGTABLES', insensitive: true) SINCE 7 days ago" -> null
}
}
- widget_log_table {
- column = 1 -> null
- facet_show_other_series = false -> null
- height = 3 -> null
- id = "295726307" -> null
- ignore_time_range = false -> null
- legend_enabled = true -> null
- row = 8 -> null
- title = "dev Check Tables Logs" -> null
- width = 8 -> null
- y_axis_left_max = 0 -> null
- y_axis_left_min = 0 -> null
# (1 unchanged attribute hidden)
- nrql_query {
- account_id = 3919076 -> null
- query = "SELECT `message` FROM Log WHERE `tags.space_name` = 'dev' AND allColumnSearch('CHECKTABLESPASS', insensitive: true) SINCE 7 days ago" -> null
}
}
- widget_log_table {
- column = 1 -> null
- facet_show_other_series = false -> null
- height = 3 -> null
- id = "295726308" -> null
- ignore_time_range = false -> null
- legend_enabled = true -> null
- row = 9 -> null
- title = "dev Missing Tables Logs" -> null
- width = 8 -> null
- y_axis_left_max = 0 -> null
- y_axis_left_min = 0 -> null
# (1 unchanged attribute hidden)
- nrql_query {
- account_id = 3919076 -> null
- query = "SELECT `message` FROM Log WHERE `tags.space_name` = 'dev' AND allColumnSearch('DBMISSINGTABLES', insensitive: true) SINCE 7 days ago" -> null
}
}
- widget_table {
- column = 1 -> null
- facet_show_other_series = false -> null
- filter_current_dashboard = false -> null
- height = 3 -> null
- id = "295726304" -> null
- ignore_time_range = false -> null
- legend_enabled = true -> null
- linked_entity_guids = [] -> null
- row = 10 -> null
- title = "dev Backups and Submissions" -> null
- width = 8 -> null
- y_axis_left_max = 0 -> null
- y_axis_left_min = 0 -> null
# (1 unchanged attribute hidden)
- nrql_query {
- account_id = 3919076 -> null
- query = "SELECT `message` FROM Log WHERE allColumnSearch('POST', insensitive: true) AND allColumnSearch('/submission/', insensitive: true) AND `newrelic.source` = 'logs.APM' AND entity.name ='dev' SINCE 2 hours ago" -> null
}
- nrql_query {
- account_id = 3919076 -> null
- query = "SELECT `message`,`timestamp` FROM Log WHERE allColumnSearch('STARTUP_CHECK', insensitive: true) AND `message` LIKE '%db_to_s3%' AND `message` LIKE '%PASS%' AND tags.space_name ='dev' SINCE 2 hours ago" -> null
}
}
- widget_table {
- column = 1 -> null
- facet_show_other_series = false -> null
- filter_current_dashboard = false -> null
- height = 3 -> null
- id = "295726305" -> null
- ignore_time_range = false -> null
- legend_enabled = true -> null
- linked_entity_guids = [] -> null
- row = 11 -> null
- title = "dev Backup and Row Count" -> null
- width = 8 -> null
- y_axis_left_max = 0 -> null
- y_axis_left_min = 0 -> null
# (1 unchanged attribute hidden)
- nrql_query {
- account_id = 3919076 -> null
- query = "SELECT `message` FROM Log WHERE `tags.space_name` = 'dev' AND allColumnSearch('\"TABLEROWCOUNT\"', insensitive: true) SINCE 2 hours ago" -> null
}
- nrql_query {
- account_id = 3919076 -> null
- query = "SELECT `message`,`timestamp` FROM Log WHERE allColumnSearch('STARTUP_CHECK', insensitive: true) AND `message` LIKE '%db_to_s3%' AND `message` LIKE '%PASS%' AND tags.space_name ='dev' SINCE 2 hours ago" -> null
}
}
- widget_table {
- column = 1 -> null
- facet_show_other_series = false -> null
- filter_current_dashboard = false -> null
- height = 3 -> null
- id = "295726306" -> null
- ignore_time_range = false -> null
- legend_enabled = true -> null
- linked_entity_guids = [] -> null
- row = 12 -> null
- title = "dev Row Count" -> null
- width = 8 -> null
- y_axis_left_max = 0 -> null
- y_axis_left_min = 0 -> null
# (1 unchanged attribute hidden)
- nrql_query {
- account_id = 3919076 -> null
- query = "SELECT `message` FROM Log WHERE `tags.space_name` = 'dev' AND allColumnSearch('\"TABLEROWCOUNT\"', insensitive: true) SINCE 7 days ago" -> null
}
}
# (13 unchanged blocks hidden)
}
}
Plan: 1 to add, 4 to change, 1 to destroy.
Warning: Argument is deprecated
with module.dev-backups-bucket.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/dev-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 6 more similar warnings elsewhere)❌ Plan not applied in Deploy to Development and Management Environment #847 (Plan has changed) |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
phildominguez-gsa
approved these changes
Oct 16, 2024
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.📝 Plan generated in Pull Request Checks #3821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to turn off finding uniqueness check. See #4385 for more details.
How to Test:
federal-awards-audit-findings-workbook.xlsx
PR Checklist: Submitter
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR Checklist: Reviewer
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.
Pre Merge Checklist: Merger
-/+ resource "null_resource" "cors_header"should be destroying and recreating its self and~ resource "cloudfoundry_app" "clamav_api"might be updating itssha256for thefac-file-scannerandfac-av-${ENV}by default.main.