Docs: update deployment steps #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LindsayYoung
reviewed
Apr 3, 2023
docs/deploying.md
Outdated
| 2. Request reviewers. | ||
| 3. Wait for the checks to pass. | ||
| 4. If checks fail, or if reviewers request changes, something has gone awry. Investigation and/or starting over from a branch and making a PR against `main` may be required. | ||
| 5. Either the reviewer or the submitter can merge the approved pull request. |
There was a problem hiding this comment.
I think only FAC Admins can merge the PR right?
There was a problem hiding this comment.
Corrected, thanks!
LindsayYoung
reviewed
Apr 3, 2023
mogul
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We altered the steps.
Pray that we do not need to
Alter them further.
Describe the current deployment steps in detail now that we appear to have GitHub actions and Terraform working.