Pre-SAC serialization bugfix #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Terraform plan for management No changes. Your infrastructure matches the configuration.📝 Plan generated in Tests for PRs #26 |
|
Terraform plan for dev No changes. Your infrastructure matches the configuration.📝 Plan generated in Tests for PRs #26 |
timoballard
commented
Apr 5, 2023
| @@ -22,7 +22,6 @@ class GeneralInformationForm(forms.Form): | |||
| auditee_contact_title = forms.CharField() | |||
| auditee_phone = forms.CharField() | |||
| auditee_email = forms.CharField() | |||
| user_provided_organization_type = forms.CharField() | |||
There was a problem hiding this comment.
this field is not actually submitted as part of the general information form, so we're removing it from the expected fields here
timoballard
commented
Apr 5, 2023
| @@ -48,7 +48,7 @@ def eligibility_check(user, data): | |||
| next_step = reverse("api-auditee-info") | |||
|
|
|||
| # Store step 0 data in profile, overwriting any pre-existing. | |||
| user.profile.entry_form_data = data | |||
| user.profile.entry_form_data = serializer.data | |||
There was a problem hiding this comment.
we should store the serialized data instead of the raw data, as the serialized data will have done the appropriate type conversions (e.g. "True" --> True)
tadhg-ohiggins
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #563
#829 implemented the General Information form, but in so doing introduced a serialization issue for two of the pre-SAC boolean fields (
met_spending_thresholdandis_usa_based). These were being stored in theUserProfileas strings, which caused a downstream failure when the general information JSON document is checked against the JSON schema, which expects them to be boolean types.