Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle affinity, anti-affinity, and topologySpreadConstraints #96

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mogul
Copy link
Collaborator

@mogul mogul commented May 3, 2022

...when auto-scaling.

Karpenter now handles pods with affinity, anti-affinity, and the Helm chart can handle topologySpreadConstraints
@mogul mogul requested a review from nickumia-reisys May 3, 2022 06:05
Copy link
Contributor

@nickumia-reisys nickumia-reisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to change anything in the karpenter provisioner that we create?

https://github.com/GSA/datagov-brokerpak-eks/blob/main/terraform/modules/provision-k8s/k8s-autoscaler.tf

@mogul
Copy link
Collaborator Author

mogul commented May 4, 2022

I don't think so because the API hasn't changed.

That said, I don't understand how it's working now with these placeholders in there... I believe I copied them from wherever you originally had the YAML when I came up with this Helm solution. Do you know what they should be?

@nickumia-reisys
Copy link
Contributor

nickumia-reisys commented May 4, 2022

Yes, I don't know how they got messed up, but,

The original solution was doing a terraform replace on those strings with correct variables.

@mogul mogul enabled auto-merge (squash) May 23, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants