-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle affinity, anti-affinity, and topologySpreadConstraints #96
base: main
Are you sure you want to change the base?
Conversation
Karpenter now handles pods with affinity, anti-affinity, and the Helm chart can handle topologySpreadConstraints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to change anything in the karpenter provisioner that we create?
I don't think so because the API hasn't changed. That said, I don't understand how it's working now with these placeholders in there... I believe I copied them from wherever you originally had the YAML when I came up with this Helm solution. Do you know what they should be? |
Yes, I don't know how they got messed up, but,
The original solution was doing a terraform replace on those strings with correct variables. |
The resources seem to already exist, they just weren't being substituted in
I thought we had one, but apparently not
...when auto-scaling.