Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump certifi from 2022.12.7 to 2023.7.22 #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jul 25, 2023

Bumps certifi from 2022.12.7 to 2023.7.22.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22.
- [Commits](certifi/python-certifi@2022.12.07...2023.07.22)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 25, 2023
@mogul
Copy link
Contributor

mogul commented Jul 28, 2023

@nickumia-reisys @rahearn this has the usual drawback of Dependabot PRs on Python code, in that it is making the PR on the lock file instead of the source of the dependencies (Pipfile, requirements.txt, or in another project, requirements.in, etc.)

I learned yesterday that dependabot also understands pip-compile and will properly make a PR against a pyproject.toml file if one exists! (checkdmarc specifies dependencies in pyproject.toml itself.)

What do you think about moving the dependencies into pyproject.toml and retiring Pipfile so Dependabot will do something more useful in future? And, what do you want to do to resolve this finding in the meantime?

@mogul
Copy link
Contributor

mogul commented Jul 28, 2023

@nickumia-reisys
Copy link
Contributor

I think that would be a step in the right direction. Data.gov has started to go in this direction with our harvesting revamp:

@mogul
Copy link
Contributor

mogul commented Aug 2, 2023

Nice! Have you turned on Dependabot PRs yet for that repo? (It no longer makes PRs automatically, which I think it did before; you have to have a .github/dependabot.yml in place for that to happen. Though it does still report results to the Security tab even when it isn't configured to make PRs.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants