"Create new form" hotfix (#127)

* Fix issue preventing navigation to new form. * Prevent saving empty forms with the initial periodic save behavior.
GSA-TTS · May 10, 2024 · beb29c8 · beb29c8
1 parent 5eb467e
commit beb29c8
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/packages/design/src/FormManager/FormList/store.ts b/packages/design/src/FormManager/FormList/store.ts
@@ -34,7 +34,18 @@ export const createFormListSlice =
         name: url,
         data,
       });
-      return context.formService.addForm(builder.form);
+      const result = await context.formService.addForm(builder.form);
+      if (result.success) {
+        return {
+          success: true,
+          data: result.data.id,
+        };
+      } else {
+        return {
+          success: false,
+          error: result.error,
+        };
+      }
     },
     createNewFormByPDFUpload: async fileDetails => {
       const builder = new BlueprintBuilder();
@@ -43,7 +54,18 @@ export const createFormListSlice =
         description: '',
       });
       await builder.addDocument(fileDetails);
-      return await context.formService.addForm(builder.form);
+      const result = await context.formService.addForm(builder.form);
+      if (result.success) {
+        return {
+          success: true,
+          data: result.data.id,
+        };
+      } else {
+        return {
+          success: false,
+          error: result.error,
+        };
+      }
     },
   });
 

diff --git a/packages/design/src/FormManager/store.tsx b/packages/design/src/FormManager/store.tsx
@@ -101,7 +101,7 @@ const savePeriodically = (store: UseBoundStore<StoreApi<FormManagerStore>>) => {
   let lastForm: Blueprint;
   setInterval(async () => {
     const { form, saveForm } = store.getState();
-    if (lastForm !== form) {
+    if (lastForm && lastForm !== form) {
       await saveForm(form);
       lastForm = form;
     }