Submit actions #358
Submit actions #358
Conversation
|
Terraform plan for tts-10x-atj-dev Plan: 0 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~ docker_image = "ghcr.io/gsa-tts/atj-platform/server-doj:266317897de2d31e9dd8524a066239bc3bb9be06" -> "ghcr.io/gsa-tts/atj-platform/server-doj:d8ad97c28e3d1a1e9223aa03f88e7a31bb7418c3"
id = "6246c063-6cf4-423d-812a-4bfdeb62bcae"
name = "tts-10x-atj-dev-server-doj-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~ docker_image = "ghcr.io/gsa-tts/atj-platform/server-kansas:266317897de2d31e9dd8524a066239bc3bb9be06" -> "ghcr.io/gsa-tts/atj-platform/server-kansas:d8ad97c28e3d1a1e9223aa03f88e7a31bb7418c3"
id = "f7c60971-bffd-4a6e-a0bb-af1191079918"
name = "tts-10x-atj-dev-server-kansas-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.📝 Plan generated in Post Terraform plan to PR comment #371 |
danielnaab
force-pushed
the
submit-actions
branch
from
e1e5d20 to
1aa82f6
Compare
…ter be registered at the plugin level. Wire this submission handler system up to the submit-form service
…nload a PDF package.
…F data serialization that need to be resolved.
danielnaab
force-pushed
the
submit-actions
branch
from
1aa82f6 to
1dbf371
Compare
| import { PatternBuilder } from '../../pattern'; | ||
| import { type InputPattern } from '.'; | ||
|
|
||
| export class Input extends PatternBuilder<InputPattern> { |
There was a problem hiding this comment.
I love the concept of the builder class here. Could we document the reasoning in an ADR?
There was a problem hiding this comment.
Will do. As it's more technical, I think it might read better as README text.
packages/forms/src/submission.ts
Outdated
| const pattern = getPattern(form, result.data.patternId); | ||
| if (pattern === undefined) { | ||
| return failure( | ||
| `asdfPattern with id ${result.data.patternId} does not exist` |
There was a problem hiding this comment.
Home row for the win 🥇 :)
There was a problem hiding this comment.
This was really nice work. There was one small issue with a typo in one file to correct, and I think an ADR that covers the need for and any plans we have for the the builder class and possibly the submit actions in this PR as a whole.
There was one commit where your message was
Add ability to register multiple handlers to the form platform, to later be registered at the plugin level. Wire this submission handler system up to the submit-form service
This might be good to document.
This branch continues work on #222, adding the ability to register multiple form submission handlers on the backend. Additionally, a "package download" pattern was added, which consists of a "Download PDF" submit button.
Actual PDF downloading is not working, due to binary/JSON serialization issues. There will be a follow-up PR to store PDF binaries in the database, outside of the form blueprint object.
This also unblocks #310.