-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslintrc for TypeScript #9
Conversation
For Alternatively, it'd be nice if we could move to the automatic runtime. ESBuild's support for it is limited at best, currently recommended to use the tl;dr, if we want auto-import: |
For the "no unused vars" in the type definitions, looks to be a combination of:
|
Thanks for helping with these! |
* Convert DailyAuthsReport to TypeScript (TSX) * Merge imports * Export ProcessedResult * Restore inline comment * Convert report.js, report.test.js to TS * Convert report-filter-controls to TSX * Remove a stray $ * Convert table to TSX - Also move numberFormatter outside of TableData * Convert routes/index, routes/report to TSX * Fix issue due to shadowing h function * Fix extension * Update eslintrc for TypeScript (#9) * Update eslintrc for TypeScript * Move custom typings to typings directory * Add global type for import.meta * Use typescript-eslint/eslint-plugin with recommended config * Auto-import h * Use ext option for ESLint extensions https://eslint.org/docs/user-guide/command-line-interface#--ext * Fix generate-routes Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Inject Fragment * Fix default= to selected= * More TypeScript * ReportRoute props types * Add return type for path function Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
I had an issue in a562b69 where I was shadowing the
h
function, which ended up breaking JSX parsingSo then I realized there should be a lint for shadowing variables like that... so this is my attempt to try to get eslint wired to catch that.
Current problem is a bunch of "defined but never used" errors that are not correct....
The one that is tripping me up is the
n
argument fromtable.jsx
...