[114] Add CI for A11y (axe-core-rspec) #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
stepchud
commented
Sep 5, 2024
Comment on lines
+1
to
+3
| <main role="main"> | ||
| <div class="usa-card__container custom-card col-md-6 rules-of-behavior"> | ||
| <h1 class="usa-card__body"> |
There was a problem hiding this comment.
These new lines fix some existing a11y issues
stepchud
commented
Sep 5, 2024
| @@ -1,5 +1,5 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <html lang="en"> | |||
stepchud
commented
Sep 5, 2024
Comment on lines
+35
to
+36
| <%= javascript_include_tag 'uswds', async: true %> | ||
| <%= javascript_include_tag 'uswds-init', async: true %> |
There was a problem hiding this comment.
fix the load order bug that caused race condition on js eval
stepchud
commented
Sep 5, 2024
| aria-labelledby="modal-1-heading" | ||
| aria-describedby="modal-1-description" | ||
| > | ||
| <dialog |
There was a problem hiding this comment.
switching to standard <dialog> component allows us to bypass the hidden button clicks that were blocking keyboard tab navigation a11y
stepchud
force-pushed
the
114-add-axe-rspec
branch
from
e9f77e9 to
626bb82
Compare
cpreisinger
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #114