New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[206] view submissions #253

Merged

stepchud merged 20 commits into dev from 206_view_submissions

Nov 6, 2024

Contributor

stonefilipczak commented Nov 4, 2024 •

edited by stepchud

Loading

Implements a submissions list view per challenge phase [#206].

Screen Shot 2024-11-04 at 10 28 27 AM

stonefilipczak added 6 commits

October 29, 2024 17:21

WIP

71a485e


          link from index


          Merge branch 'dev' into 206_view_submissions

2db488a


          tests

dd46f8c


          helper methods

a328be1


          icons

b76cae6

stepchud self-requested a review

November 4, 2024 16:35

stepchud added the frontend label

stepchud linked an issue

that may be closed by this pull request

Create View Submissions page #206

Closed

6 tasks

stepchud reviewed

View reviewed changes

app/controllers/manage_submissions_controller.rb Outdated Show resolved Hide resolved

stepchud reviewed

View reviewed changes

app/helpers/manage_submissions_helper.rb Outdated Show resolved Hide resolved

stepchud reviewed

View reviewed changes

spec/system/logins_spec.rb Outdated Show resolved Hide resolved

stepchud reviewed

View reviewed changes

spec/system/logins_spec.rb Outdated Show resolved Hide resolved


          Merge remote-tracking branch 'origin/dev' into 206_view_submissions

340da9d

stepchud reviewed

View reviewed changes

Contributor

stepchud left a comment •

edited

Loading

a few differences with the figma mockup:

~~Eligible, Selected status rows on mobile and desktop~~ this works for now given uswds implementation
Mobile view has the header Average Score
- "(of completed evaluations)" can be removed from the design implementation
Mobile view has Submission ID label for the first field


          add submission id label on mobile

2a651eb

stepchud reviewed

View reviewed changes

app/views/manage_submissions/_submissions_table.html.erb Outdated Show resolved Hide resolved

stepchud reviewed

View reviewed changes

app/views/manage_submissions/_phases_table.html.erb Outdated Show resolved Hide resolved

stepchud reviewed

View reviewed changes

app/views/manage_submissions/_submissions_table.html.erb Outdated Show resolved Hide resolved

r-bartlett-gsa added this to the Sprint 11/05/24 milestone

stonefilipczak and others added 7 commits

November 5, 2024 14:11


          Update app/controllers/manage_submissions_controller.rb

e5fc225

Co-authored-by: Stephen Chudleigh <stepchud@users.noreply.github.com>


          Update app/views/manage_submissions/_submissions_table.html.erb

cacbaae

Co-authored-by: Stephen Chudleigh <stepchud@users.noreply.github.com>


          Update app/helpers/manage_submissions_helper.rb

c83efc7

Co-authored-by: Stephen Chudleigh <stepchud@users.noreply.github.com>


          scope phase to a user's challenges

e9d73f5


          move tests into own file


          rubocop

b82b779


          add closing a tag

a2e7ed7

stepchud reviewed

View reviewed changes

app/views/manage_submissions/_submissions_table.html.erb Outdated Show resolved Hide resolved


          add margin-right-1 to all icons

cde14f4

r-bartlett-gsa removed this from the Sprint 11/05/24 milestone

r-bartlett-gsa added this to the Sprint 11/19/24 milestone

stonefilipczak added 3 commits

November 6, 2024 13:33


          testing different states

eaca5b8


          display booleans as checkboxes on desktop


          rubocop

389a1b2

stonefilipczak requested a review from stepchud

November 6, 2024 19:40


          nested routes

e7300b3

stepchud approved these changes

View reviewed changes

Contributor

stepchud left a comment

Looks good to me, btw I updated the route and made some other small changes here e7300b3

stepchud merged commit b48aef2 into dev

11 checks passed

stepchud deleted the 206_view_submissions branch

November 6, 2024 22:26

cpreisinger added a commit that referenced this pull request


          Merge branch 'dev' of github.com:GSA/Challenge_platform into 248/eval…

c2fe756

…-form-browser-automation-specs

* 'dev' of github.com:GSA/Challenge_platform:
  [206] view submissions (#253)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels