[74] Enter Evaluators A11y Fix #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
67 tasks
stepchud
reviewed
Jan 7, 2025
stepchud
reviewed
Jan 7, 2025
stepchud
reviewed
Jan 7, 2025
stepchud
previously requested changes
Jan 9, 2025
stepchud
reviewed
Jan 15, 2025
| def add_existing_user_as_evaluator(user) | ||
| return user_already_added(user) if @phase.evaluators.include?(user) | ||
| return invalid_role(user) unless User::VALID_EVALUATOR_ROLES.include?(user.role) | ||
|
|
||
| if @invitation_params[:full_name].present? |
There was a problem hiding this comment.
I thought full_name param was required, why is it optional here?
There was a problem hiding this comment.
Yeah you're right - now that full_name is required and used in the validations, I don't need that check. Some of the tests weren't including the full_name. I removed that check and updated the tests. Should be good to go, thx! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: #200 #74
Figma
Changes made in this PR:
when adding that user as an evaluator to a challenge phase,
then require and update the user with the provided first and last name.
Updated UI
Validation errors
Empty form
Only a first name
Missing last name
User with invalid role
Required first and last name for existing user
Existing user without first and last name updated with name entered
Mobile
WAVE