[38] Create Rails User model #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bilalhankins
commented
Jul 18, 2024
bilalhankins
commented
- Replicated user model from challenge_gov Elixir schema using the schema_to_scaffold gem
stepchud
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Now that I've seen this, it doesn't look very useful. I'm not even sure we need the view helpers TBH. I think all we really want are the app/models and spec/models classes but those can be created pretty easily without the schema_to_scaffold gem. instead let's try using https://github.com/ctran/annotate_models to add code comments to the model class based on the current schema.
…ge_platform into 38/create-user-model
stepchud
reviewed
Jul 23, 2024
app/models/user.rb
Outdated
Comment on lines
44
to
45
| # Virtual Attributes | ||
| attr_accessor :email_confirmation, :password, :password_confirmation |
There was a problem hiding this comment.
the docs for the attribute method say it doesn't need to be backed by the DB. however, I'm not sure that we need these attributes anyways. AFAIK users shouldn't be able to reset their login.gov password from the app, and I don't know about the email_confirmation.
Co-authored-by: Stephen Chudleigh <stepchud@users.noreply.github.com>
stepchud
approved these changes
Jul 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.