Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove future and see who is complaining #718

Closed
wants to merge 1 commit into from
Closed

remove future and see who is complaining #718

wants to merge 1 commit into from

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Jan 10, 2023

For GSA/data.gov#4145

This is trial-and-error, by removing future and adding py2 condition in the import statement where ever it complains missing future, hopefully we can becoming future-less.

btylerburton
btylerburton approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rerunning Build & Test to see if it passes. If so, let's pull off the bandaid and see what breaks.

@FuhuXia
Copy link
Member Author

FuhuXia commented Jan 18, 2023 •
edited
Loading

Found ckanext-archiver is complaining. Made an effort to remove its dependency on future but then future is patched now. New PR is ready to do the patch. Close this one.

@FuhuXia FuhuXia closed this Jan 18, 2023
@btylerburton btylerburton deleted the future-is-history branch April 14, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btylerburton btylerburton btylerburton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FuhuXia @btylerburton