Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto ckan start time #850

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Fix auto ckan start time #850

merged 4 commits into from
Mar 3, 2023

Conversation

nickumia-reisys
Copy link
Contributor

@nickumia-reisys nickumia-reisys commented Mar 3, 2023 •
edited
Loading

@nickumia-reisys nickumia-reisys requested a review from a team March 3, 2023 18:01
@nickumia-reisys nickumia-reisys disabled auto-merge March 3, 2023 18:02
btylerburton
btylerburton previously approved these changes Mar 3, 2023
View reviewed changes
@nickumia-reisys nickumia-reisys marked this pull request as draft March 3, 2023 18:18
nickumia-reisys and others added 2 commits March 3, 2023 14:32
@nickumia-reisys
Merge branch 'main' into fix-audit-issues
ff4d73f
@nickumia-reisys
new: dynamically generate matrix to use variables
2b564b5 
The only way to use variables in the matrix is to dynamically pre-generate it
@nickumia-reisys nickumia-reisys requested review from a team and btylerburton March 3, 2023 20:56
@nickumia-reisys nickumia-reisys marked this pull request as ready for review March 3, 2023 20:56
@nickumia-reisys
Copy link
Contributor Author

Test run case: https://github.com/nickumia-reisys/github-action-test/actions/runs/4327171283

btylerburton
btylerburton approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean!

@nickumia-reisys nickumia-reisys merged commit d92e77b into main Mar 3, 2023
@nickumia-reisys nickumia-reisys deleted the fix-audit-issues branch March 3, 2023 22:39
This was referenced Mar 3, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btylerburton btylerburton btylerburton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickumia-reisys @btylerburton