Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds job cancel methods, route and template UI #107

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Adds job cancel methods, route and template UI #107

merged 2 commits into from
Nov 6, 2024

Conversation

btylerburton
Copy link
Contributor

Pull Request

Related to:

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?

@btylerburton btylerburton requested a review from a team November 5, 2024 22:56
@btylerburton
Copy link
Contributor Author

Fail to deploy to staging expected as there is no app in staging 😄

jbrown-xentity
jbrown-xentity approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question!

app/templates/view_job_data.html Show resolved Hide resolved
@btylerburton btylerburton merged commit c842d24 into main Nov 6, 2024
8 of 9 checks passed
@btylerburton btylerburton deleted the adds-job-cancel-route branch November 6, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrown-xentity jbrown-xentity jbrown-xentity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btylerburton @jbrown-xentity