Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIGITAL-240: Patch allowed CSS chars #100

Closed
wants to merge 1 commit into from

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Jan 3, 2025

Jira ticket

DIGITAL-240

Purpose

  • Adds drupal core patch to allow colons and other valid CSS identifiers in classes specified via Views UI

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

composer install should patch core

QA/Testing instructions

Find or create a view where classes have been customized with identifiers that include a :. View rendered output for the view and confirm the classes in the HTML have the : in them.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

* Adds drupal core patch to allow colons and other valid CSS identifiers in classes specified via Views UI
@omerida omerida requested a review from clmedders January 3, 2025 20:41
@omerida omerida closed this Jan 3, 2025
@omerida omerida deleted the feature/DIGITAL-240-views-colons branch January 3, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant