DIGITAL-37: Migrate links paragraph templates. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds paragraph_view_mode module. Migrate template for featured links field display. Adds separate templates for default and featured links views of resources. Updates featured links template with correct markup. Switch shortcodes to use theme templates for resources.
omerida
force-pushed
the
feature/DIGITAL-37-resource-paragraphs
branch
from
151716b to
932bbc7
Compare
…-resource-paragraphs # Conflicts: # composer.lock # composer.log # web/themes/custom/digital_gov/digital_gov.theme
Adds a twig function templates can use to determine logo to use for a given URL.
mattsqd
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Looks like the paragraphs are not rendering on the topics
https://digital.gov/topics/accessibility/
Adds a twig function to get the favicon URI via Google.
…graphs' into feature/DIGITAL-37-resource-paragraphs
…-resource-paragraphs # Conflicts: # composer.lock # composer.log # web/modules/custom/ec_shortcodes/templates/ec-shortcodes-featured-resource-ext.html.twig # web/modules/custom/ec_shortcodes/templates/ec-shortcodes-featured-resource.html.twig # web/themes/custom/digital_gov/templates/node/node--topics.html.twig
|
@mattsqd do you need any more changes on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
DIGITAL-37
Purpose
Adds paragraph_view_mode module.
Migrate template for featured links field display. Adds separate templates for default and featured links views of resources. Updates featured links template with correct markup. Switch shortcodes to use theme templates for resources.
It can be helpful to understand:
Includes the following PRs that must be merged first
Deployment and testing
Local Setup
bin/drush cimto get paragraph type updatesbin/drush crto refresh theme template cacheQA/Testing instructions
Edit a topic page, add one or more internal and external resources
Confirm they use the expected HTML from the featured-links template
Override the title, summary for resources and confirm overrides are used
Checklist for the Developer
Checklist for the Peer Reviewers