-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digital-119: Configure images #59
Conversation
…9-configure-images # Conflicts: # composer.json # composer.lock # composer.log # config/sync/core.entity_form_display.node.basic_page.default.yml # config/sync/core.entity_form_display.node.community.default.yml # config/sync/core.entity_form_display.node.news.default.yml # config/sync/core.extension.yml
7e47dca
to
4a4650e
Compare
4a4650e
to
78521e0
Compare
…ure-images # Conflicts: # composer.lock # composer.log # config/sync/core.entity_form_display.media.image.default.yml # config/sync/core.entity_form_display.node.community.default.yml # config/sync/core.entity_form_display.node.topics.default.yml # config/sync/core.entity_view_display.media.image.default.yml # config/sync/core.extension.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, only thing I see is that 'Media Library Edit' is not configured for all fields. For example, I went to basic page and there was no edit button on the Primary Image.
How do you configure? It's every media field we have, so go to http://digitalgov.lndo.site/admin/reports/fields and look for 'Reference type: Media', then go to 'Manage form display' for each content type and each media field, and click the little gear:
…ure/DIGITAL-119-configure-images # Conflicts: # composer.lock # composer.log
…/digital-gov-drupal into feature/DIGITAL-119-configure-images
…9-configure-images # Conflicts: # composer.lock
Jira ticket
DIGITAL-119
Purpose
Acceptance Criteria:
<img src="https://s3.amazonaws.com/digitalgov/woman-touching-the-virtual-future-interface_w1200.jpg" alt="Woman touching a virtual interface." srcset="https://s3.amazonaws.com/digitalgov/woman-touching-the-virtual-future-interface_w800.jpg 800w,https://s3.amazonaws.com/digitalgov/woman-touching-the-virtual-future-interface_w1200.jpg 1200w " sizes="(max-width: 800px) 100vw, (max-width: 1200px) 100vw, 100vw">
Local Setup
QA/Testing instructions
Test responsive images:
Checklist for the Developer
Checklist for the Peer Reviewers