Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory-item-has-hardware-model Constraint #1088

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Jan 9, 2025

Committer Notes

Purpose

This PR aims to add the inventory-item-has-hardware-model constraint which ensures that hardware model information is provided for hardware components / inventory items.

Changes

Added constraint:

  • inventory-item-has-hardware-model

Added valid/invalid test content:

  • ssp-inventory-item-has-hardware-model-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraint

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Jan 9, 2025
@Gabeblis Gabeblis requested a review from a team as a code owner January 9, 2025 15:54
@Gabeblis Gabeblis linked an issue Jan 9, 2025 that may be closed by this pull request
15 tasks
@Gabeblis Gabeblis force-pushed the constraints/issue-1041 branch 3 times, most recently from 343edee to 4c0efa1 Compare January 9, 2025 16:13
@Gabeblis Gabeblis changed the base branch from develop to canary January 9, 2025 16:24
@Gabeblis Gabeblis force-pushed the constraints/issue-1041 branch 2 times, most recently from 2e0b7f0 to 56e3e28 Compare January 9, 2025 16:33
wandmagic
wandmagic previously approved these changes Jan 9, 2025
aj-stein-gsa
aj-stein-gsa previously approved these changes Feb 13, 2025
@Gabeblis Gabeblis force-pushed the constraints/issue-1041 branch 2 times, most recently from 6a6f032 to 776d0ff Compare February 14, 2025 16:35
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Gabeblis. Sorry I didn't mention the example ssp changes earlier.

Also, per discussion at stand up, a hardware inventory item can be specified:

  1. by adding an "asset-type" prop with "hardware" value to the inventory-item
  2. by having the inventory-item reference (via implemented-component\component-uuid) a component that has a "asset-type" prop with value of "hardware"
  3. by having the inventory-item reference (via implemented-component\component-uuid) a component of type "hardware"

Please account for that 3rd case in the constraint and it should be good to go. thx

@Gabeblis Gabeblis force-pushed the constraints/issue-1041 branch from 776d0ff to a6bb53f Compare February 14, 2025 16:42
@Gabeblis
Copy link
Contributor Author

@Rene2mt I just noticed the extra hardware-model props as well. Those have been removed 👍

@Gabeblis Gabeblis requested a review from Rene2mt February 14, 2025 16:43
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good.

@Gabeblis Gabeblis merged commit ef577e3 into GSA:canary Feb 19, 2025
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - Hardware Model
4 participants