improve constraint coverage tests #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Waltermire <davewaltermire@gmail.com>
Co-authored-by: David Waltermire <davewaltermire@gmail.com>
Co-authored-by: David Waltermire <davewaltermire@gmail.com>
david-waltermire
approved these changes
Aug 22, 2024
Rene2mt
approved these changes
Aug 22, 2024
aj-stein-gsa
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Improve constraint coverage tests * Update features/steps/fedramp_extensions_steps.ts --------- Co-authored-by: David Waltermire <davewaltermire@gmail.com>
aj-stein-gsa
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Improve constraint coverage tests * Update features/steps/fedramp_extensions_steps.ts --------- Co-authored-by: David Waltermire <davewaltermire@gmail.com>
Rene2mt
pushed a commit
to Rene2mt/fedramp-automation
that referenced
this pull request
Sep 27, 2024
* Improve constraint coverage tests * Update features/steps/fedramp_extensions_steps.ts --------- Co-authored-by: David Waltermire <davewaltermire@gmail.com>
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
* Improve constraint coverage tests * Update features/steps/fedramp_extensions_steps.ts --------- Co-authored-by: David Waltermire <davewaltermire@gmail.com>
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
nothing crazy here just an improvement on detecting constraints and assuring coverage
anything with an ID in a constraint file is considered a constraint
and each constraint gets its own "scenario" so we can get a red or green check if its covered or not
also allows npm run:coverage to test coverage and npm run test:constraints to run each part off the test suite independently
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.