Feature/data center constraints #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-gsa
requested changes
Aug 29, 2024
aj-stein-gsa
requested changes
Sep 10, 2024
aj-stein-gsa
approved these changes
Sep 10, 2024
aj-stein-gsa
previously approved these changes
Sep 10, 2024
|
Sigh, I now need to rebase this one. 😦 |
Co-authored-by: A.J. Stein <aj@gsa.gov>
Co-authored-by: A.J. Stein <aj@gsa.gov>
Co-authored-by: A.J. Stein <aj@gsa.gov>
aj-stein-gsa
force-pushed
the
feature/data-center-constraints
branch
from
8abc34f
to
ce8e19a
Compare
aj-stein-gsa
approved these changes
Sep 10, 2024
aj-stein-gsa
merged commit 7929a55
into
GSA:feature/external-constraints
3 checks passed
aj-stein-gsa
added a commit
that referenced
this pull request
Sep 24, 2024
* introduce data center constraints * complete data center constraints * Update src/validations/constraints/content/ssp-all-INVALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/content/ssp-all-VALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/content/ssp-location-INVALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * remove allowed-type data center country code * Late review feedback: align country code example with constraint * Fix the correction that broke negative testing, sorry Paul --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
aj-stein-gsa
added a commit
that referenced
this pull request
Sep 25, 2024
* introduce data center constraints * complete data center constraints * Update src/validations/constraints/content/ssp-all-INVALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/content/ssp-all-VALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/content/ssp-location-INVALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * remove allowed-type data center country code * Late review feedback: align country code example with constraint * Fix the correction that broke negative testing, sorry Paul --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
Rene2mt
pushed a commit
to Rene2mt/fedramp-automation
that referenced
this pull request
Sep 27, 2024
* introduce data center constraints * complete data center constraints * Update src/validations/constraints/content/ssp-all-INVALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/content/ssp-all-VALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/content/ssp-location-INVALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * remove allowed-type data center country code * Late review feedback: align country code example with constraint * Fix the correction that broke negative testing, sorry Paul --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
* introduce data center constraints * complete data center constraints * Update src/validations/constraints/content/ssp-all-INVALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/content/ssp-all-VALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/content/ssp-location-INVALID.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * remove allowed-type data center country code * Late review feedback: align country code example with constraint * Fix the correction that broke negative testing, sorry Paul --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Introducing fully covered data center constraints
All Submissions:
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.