Add back-matter constraints resource-has-{title,rlink}

[Gabeblis]

Committer Notes

Description

Added back-matter constraints and tests for each of the constraints. These should be added as they are part of the effort write all of the constraints from the constraint tracker.

Changes

• Added constraints resource-has-title and resource-has-rlink to fedramp-external-constraints.xml.
• Added pass and fail yaml tests for both of the above constraints.
• Edited ssp-all-INVALID to ensure both constraints fail correctly.

{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}

All Submissions:

• Have you selected the correct base branch per Contributing guidance?
• Have you set "Allow edits and access to secrets by maintainers"?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you squashed any non-relevant commits and commit messages? [instructions]
• Have you added an explanation of what your changes do and why you'd like us to include them?
• If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? Yes, Citations (back-matter/resources) SHOULD have a title automate.fedramp.gov#49
• If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

[aj-stein-gsa]

Can you base this against #649? I tested this locally before rebase and got errors with the tests other than we discussed when pairing today. I will stitch than in here, but errors went away rebasing and want to make sure before we pull all this in.

Thanks in advance for doing that.

[Gabeblis]

Can you base this against #649? I tested this locally before rebase and got errors with the tests other than we discussed when pairing today. I will stitch than in here, but errors went away rebasing and want to make sure before we pull all this in.

Thanks in advance for doing that.

Thanks for the review! I rebased and have no errors. All tests are passing.

[aj-stein-gsa]

Can you base this against #649? I tested this locally before rebase and got errors with the tests other than we discussed when pairing today. I will stitch than in here, but errors went away rebasing and want to make sure before we pull all this in.
Thanks in advance for doing that.

Thanks for the review! I rebased and have no errors. All tests are passing.

Was the constraints and failing test the ones you showed me earlier today with the UUID look up to cross-ref a logo for party's logo in metadata back to a resource? Or is that work going into a separate PR to be filed later and just had issues WIPing locally on your computer?

[aj-stein-gsa]

Aside from my questions about the test discussed when pairing, this looks good to go from my perspective. 🚢

[Gabeblis]

Can you base this against #649? I tested this locally before rebase and got errors with the tests other than we discussed when pairing today. I will stitch than in here, but errors went away rebasing and want to make sure before we pull all this in.
Thanks in advance for doing that.

Thanks for the review! I rebased and have no errors. All tests are passing.

Was the constraints and failing test the ones you showed me earlier today with the UUID look up to cross-ref a logo for party's logo in metadata back to a resource? Or is that work going into a separate PR to be filed later and just had issues WIPing locally on your computer?

I was working on the constraint we were discussing earlier in a local branch, and I haven't pushed anything to GitHub yet. That was the resource-is-referenced constraint, and it isn't part of this PR. I'll open a separate PR for it when I have the issue resolved.

[aj-stein-gsa]

I was working on the constraint we were discussing earlier in a local branch, and I haven't pushed anything to GitHub yet. That was the resource-is-referenced constraint, and it isn't part of this PR. I'll open a separate PR for it when I have the issue resolved.

No worries, we can carry on convo outside of this PR review. I have approved, you get to pull the trigger to merge in. 🫡

[aj-stein-gsa]

Before final merge tomorrow, we should determine what we expect to see in the corresponding documentation. I did notice automate.fedramp.gov talks about the title for resources but doesn't say it is mandatory. Also I now see there is a little more nuance to the constraint requirements than I knew from memory per below and information about base64, rlink, neither or both being permissible in different contexts. Apologies.

https://automate.fedramp.gov/documentation/general-concepts/oscal-citations-and-attachments/

[aj-stein-gsa]

I will approve, but let's make sure GSA/automate.fedramp.gov#49 PR is merged along with this for docs alignment, but this is looking good.

[aj-stein-gsa]

Thanks for humoring the feedback and the file renames after the constraint changes.