Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defined identifiers values for only FedRAMP role types. #68

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

ohsh6o
Copy link
Contributor

@ohsh6o ohsh6o commented Dec 8, 2020

Per discussion over pending work in 18F#32, we want
to further enhance the XML content defined in the FedRAMP Registry as
saved in the Excel XSLX file to include defined identifiers for roles
particular to FedRAMP not the current milestone release of upstream
OSCAL.

Per discussion over pending work in #32, we want
to further enhance the XML content defined in the FedRAMP Registry as
saved in the Excel XSLX file to include defined identifiers for roles
particular to FedRAMP not the current milestone release of upstream
OSCAL.
@ohsh6o
Copy link
Contributor Author

ohsh6o commented Dec 8, 2020

Also, related to 18F#32, I know this might be early, but I did not add cardinality as discussed in #65, as I think we need to discuss some more before I try adding that here.

CC @mike-stern

Copy link
Contributor

@brian-ruf brian-ruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-ruf brian-ruf merged commit 019a339 into GSA:master Jan 4, 2021
@brian-ruf brian-ruf deleted the issue-32-add-fedramp-roles branch January 4, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants