Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce missing-response-components constraint #688

Conversation

wandmagic
Copy link
Collaborator

Committer Notes

Introduce check for missing by-component responses.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner September 12, 2024 14:39
@aj-stein-gsa aj-stein-gsa force-pushed the feature/missing-response-components branch from 75b0626 to 1384b32 Compare September 16, 2024 14:23
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put in adjustments on message wording and prepped this for merge after reviewing documentation, looks good.

@aj-stein-gsa aj-stein-gsa merged commit 182bff0 into GSA:feature/external-constraints Sep 16, 2024
3 checks passed
aj-stein-gsa added a commit that referenced this pull request Sep 24, 2024
* introduce missing-response-components constraint

* Add review feedback from AJ before merge

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
aj-stein-gsa added a commit that referenced this pull request Sep 25, 2024
* introduce missing-response-components constraint

* Add review feedback from AJ before merge

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
Rene2mt pushed a commit to Rene2mt/fedramp-automation that referenced this pull request Sep 27, 2024
* introduce missing-response-components constraint

* Add review feedback from AJ before merge

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
* introduce missing-response-components constraint

* Add review feedback from AJ before merge

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚢 Ready to Ship
Development

Successfully merging this pull request may close these issues.

2 participants