Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim invalid test data files #721

Conversation

Gabeblis
Copy link

Committer Notes

Description

Trimmed all INVALID.xml files down to minimum necessary content. These changes should be added as they are part of the effort write all of the constraints from the constraint tracker.

Changes

  • Modified all -INVALID.xml files for constraints in feature-external-constraints.xml and feature-external-allowed-values.xml to contain the minimum necessary content to trigger the constraint and successfully fail.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis requested a review from a team as a code owner September 24, 2024 17:14
@Gabeblis Gabeblis changed the title Trimmed all files down to minimum necessary content Trimmed invalid test data files Sep 24, 2024
@Gabeblis Gabeblis changed the title Trimmed invalid test data files Trim invalid test data files Sep 24, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way.

@aj-stein-gsa aj-stein-gsa merged commit d3c4bc8 into GSA:feature/external-constraints Sep 24, 2024
3 checks passed
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants