Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation of errors and failure for debugging #722

Merged

Conversation

aj-stein-gsa
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa commented Sep 24, 2024

Committer Notes

Closes #696.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@aj-stein-gsa aj-stein-gsa self-assigned this Sep 24, 2024
@aj-stein-gsa aj-stein-gsa marked this pull request as ready for review September 24, 2024 21:48
@aj-stein-gsa aj-stein-gsa requested a review from a team as a code owner September 24, 2024 21:48
@wandmagic
Copy link
Collaborator

looks good to me

Rene2mt
Rene2mt previously approved these changes Sep 25, 2024
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo but not a blocking change as we need this for Wednesday.

src/validations/constraints/README.md Outdated Show resolved Hide resolved
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
@aj-stein-gsa aj-stein-gsa removed the request for review from Gabeblis September 25, 2024 02:12
@aj-stein-gsa aj-stein-gsa merged commit 42d2219 into GSA:feature/external-constraints Sep 25, 2024
Copy link

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid

brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants