Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container-based debugging info for CONTRIBUTING.md #725

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Add container-based debugging info for CONTRIBUTING.md #725

merged 5 commits into from
Sep 25, 2024

Conversation

aj-stein-gsa
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa commented Sep 25, 2024 •
edited
Loading

Committer Notes

Closes #697.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?
  • If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated? Updates developer docs only, but still relevant. I will cross this req out.

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@aj-stein-gsa aj-stein-gsa requested a review from a team as a code owner September 25, 2024 05:24
@aj-stein-gsa aj-stein-gsa changed the base branch from master to feature/external-constraints September 25, 2024 05:24
@aj-stein-gsa aj-stein-gsa self-assigned this Sep 25, 2024
Gabeblis
Gabeblis approved these changes Sep 25, 2024
View reviewed changes
Copy link

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aj-stein-gsa aj-stein-gsa removed the request for review from Rene2mt September 25, 2024 14:12
@aj-stein-gsa aj-stein-gsa merged commit 11f490d into GSA:feature/external-constraints Sep 25, 2024
aj-stein-gsa added a commit that referenced this pull request Sep 25, 2024
@aj-stein-gsa
Add container-based debugging info for CONTRIBUTING.md (#725)
edc2996 
* [skip ci] Fix Makefile menu items for #697

* [skip ci] Add container debug approach for #697

* [skip ci] Fix docker cmd formatting for #697

* [skip ci] Fix docs, add entrypoint info for #697

* [skip ci] Path important for docker mounts in #697
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
@aj-stein-gsa @brian-ruf
Add container-based debugging info for CONTRIBUTING.md (GSA#725)
1f4e580 
* [skip ci] Fix Makefile menu items for GSA#697

* [skip ci] Add container debug approach for GSA#697

* [skip ci] Fix docker cmd formatting for GSA#697

* [skip ci] Fix docs, add entrypoint info for GSA#697

* [skip ci] Path important for docker mounts in GSA#697
This was referenced Nov 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabeblis Gabeblis Gabeblis approved these changes

Assignees

@aj-stein-gsa aj-stein-gsa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport container usage and debugging for developer docs
2 participants
@aj-stein-gsa @Gabeblis