Add virtual, public, and allows-authenticated-scan allowed values #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-gsa
requested changes
Sep 25, 2024
There was a problem hiding this comment.
This looks very good, there is just some minor adjustments (maybe git fetch --all && git pull -r upstream feature/external-constraints) and some minor ID changes? With those issues fixed, I would be ready to approve and merge.
Let us know if you need help on integrating this feedback.
src/validations/constraints/fedramp-external-allowed-values.xml
Outdated
Show resolved
Hide resolved
src/validations/constraints/fedramp-external-allowed-values.xml
Outdated
Show resolved
Hide resolved
src/validations/constraints/fedramp-external-allowed-values.xml
Outdated
Show resolved
Hide resolved
aj-stein-gsa
approved these changes
Sep 25, 2024
aj-stein-gsa
merged commit 7c27cc5
into
GSA:feature/external-constraints
3 checks passed
aj-stein-gsa
added a commit
that referenced
this pull request
Sep 25, 2024
* Add allowed-values (virtual, public, allows-authenticated-scan) * Add YAML and ssp-virtual-INVALID..xml * Add YAML and INVALID for public and authorized-scan allowed values. * Rebase the branch and add "inventory-item" to constraints * Fix feature inventory of tests per feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
…A#728) * Add allowed-values (virtual, public, allows-authenticated-scan) * Add YAML and ssp-virtual-INVALID..xml * Add YAML and INVALID for public and authorized-scan allowed values. * Rebase the branch and add "inventory-item" to constraints * Fix feature inventory of tests per feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
All Submissions:
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.