Don't make dupe ADR 6, properly number ADR 8 #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-gsa
force-pushed
the
bug-renumber-adr-8-correctly
branch
from
2babd97 to
0e682c7
Compare
Also, you know, kind of an important recommendation. 😆 |
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
* [skip ci] No dupe ADR 6, properly number ADR 8 * [skip ci] Rename file from ADR 6 -> ADR 8 * [skip ci] 0-pad ADR 7 filename to match others * Updated ADR GSA#8 status --------- Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
When attempting to review a PR and include its contents in feedback, I realized this ADR is not properly number. It was created and approved after ADR 7. This quickly changes the file name and ID in the document.
All Submissions:
If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated?If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.