Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix constraint script for windows #740

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Conversation

wandmagic
Copy link

Committer Notes

After switching the run environment of the dev-constraint script we neglected to update our method of finding the constraint directory path for windows.

this adds a github action to assure that the test script runs correctly in windows and linux

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner September 28, 2024 14:11
@wandmagic
Copy link
Author

if we don't want the github action let me know, just want to make sure i didn't break linux support as I fixed this on my windows box

.github/workflows/test-scripts.yml Outdated Show resolved Hide resolved
.github/workflows/test-scripts.yml Outdated Show resolved Hide resolved
.github/workflows/test-scripts.yml Outdated Show resolved Hide resolved
@aj-stein-gsa
Copy link
Contributor

if we don't want the github action let me know, just want to make sure i didn't break linux support as I fixed this on my windows box

I am fine with that. Sorry for minor nits, I am fine with the action to test across platforms and everything else looks great.

aj-stein-gsa
aj-stein-gsa previously approved these changes Sep 30, 2024
@wandmagic
Copy link
Author

output of the windows test doesn't fail but is not behaving as expected?!
I'm going to re-test on my windows box again before we merge this

@wandmagic
Copy link
Author

OK this should be good to go now, just needed a small tweak to the command execSync

@wandmagic wandmagic merged commit 478908e into GSA:develop Sep 30, 2024
5 checks passed
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
* hotfix constraint script for windows

* Update test-scripts.yml

* remove debug log

* Update test-scripts.yml

* update dev constraint

* Update dev-constraint.js

* sort files listed from directories
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants