-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information-type-800-60-v2r1 #764
Add information-type-800-60-v2r1 #764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Very, very close, but I would recommend one important change.
src/validations/constraints/fedramp-external-allowed-values.xml
Outdated
Show resolved
Hide resolved
I am going to propose some improvements around positive and negative tests, as discussed in standup, @DimitriZhurkin, one moment. |
See the following comment for more details. GSA#764 (comment)
See the following comment for more details. GSA#764 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's expand some of the tests and discuss changes in my recommendations in the PR (I cannot use suggestions for files out of scope for the PR).
I DMed in the team chat to further discuss the implications here. I want more robust tests based on other bugs I have seen reported and want to make sure we fully test the mechanics in positive and negative tests if possible.
I tried your suggestions, and I'll commit the changes to |
It took me some time to figure out why but I read through the output and I understand now. I will complete my review on this request. |
* Add information-type-800-60-v2r1 * In target, add system URL ([@System='https://doi.org/10.6028/NIST.SP.800-60v2r1']) * In ssp-information-type-id-INVALID.xml, add another invalid information-type-id
* Add information-type-800-60-v2r1 * In target, add system URL ([@System='https://doi.org/10.6028/NIST.SP.800-60v2r1']) * In ssp-information-type-id-INVALID.xml, add another invalid information-type-id
Committer Notes
In
fedramp-external-allowed-values.xml
, add theinformation-type-800-60-v2r1
constraint.All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.