Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

640 readme cleanup #771

Merged
merged 31 commits into from
Oct 30, 2024
Merged

640 readme cleanup #771

merged 31 commits into from
Oct 30, 2024

Conversation

kyhu65867
Copy link

@kyhu65867 kyhu65867 commented Oct 10, 2024

Committer Notes

{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@kyhu65867 kyhu65867 requested a review from a team as a code owner October 10, 2024 21:04
@kyhu65867 kyhu65867 changed the base branch from master to develop October 10, 2024 21:05
@aj-stein-gsa aj-stein-gsa marked this pull request as draft October 10, 2024 21:16
@aj-stein-gsa
Copy link
Contributor

@kyhu65867 thanks for the time today and pushing up the work, I will review once you have finished more of the work and mark it as ready for review from us. 😄

@kyhu65867
Copy link
Author

I addressed most of issue 640 and some of issue 739. Still in progress but I think it's a significant improvement from where it was before

@kyhu65867
Copy link
Author

kyhu65867 commented Oct 11, 2024

I think the main readme is in a good place. I'm going to un-draft this, please let me know what you think!

@kyhu65867 kyhu65867 closed this Oct 11, 2024
@kyhu65867 kyhu65867 reopened this Oct 11, 2024
@kyhu65867 kyhu65867 marked this pull request as ready for review October 11, 2024 15:35
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a general question, are we going to move the constraint README for development here and delete those files? Is this PR part of a series of such improvements or this going to be the end of this work?

(Sorry, typed this review question, but had not submitted. It's a few hours old.)

@kyhu65867
Copy link
Author

I didn't know if we wanted to move the constraints readme just because I wanted this readme to be a general overview of everything this repo has and I think in its final form the repo will have more than just the constraints tooling (unless I'm wrong). I also could see this becoming a series of improvements, especially since there are a bunch of dead readme files scattered throughout the repo. But I think that is a part of a bigger project of "decluttering" so that we can have as streamlined and clear of a readme as possible. It's hard to make a streamlined and clear readme with sort of a clunky repo (no offense)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
brian-ruf
brian-ruf previously approved these changes Oct 17, 2024
Copy link
Collaborator

@brian-ruf brian-ruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deleted my own erroneous review]

@brian-ruf brian-ruf dismissed their stale review October 17, 2024 14:16

I thought I was approving one change, not the whole PR.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes and recommendations. There is a lot. We can talk through it later if you like.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor touchups before a more thorough review. Also it looks like we need to rebase your branch as a bunch of constraint file changes are in the PR now that are not related to the README edits. That happens.

We are very close!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@kyhu65867 kyhu65867 requested a review from a team October 29, 2024 13:27
@aj-stein-gsa aj-stein-gsa merged commit cb9f6b4 into GSA:develop Oct 30, 2024
5 checks passed
wandmagic pushed a commit that referenced this pull request Nov 1, 2024
* fixed error in the OSCAL deprecation strategy section that implied that an oscal version 1.0.0 would not support 1.0.1 +

* updated Rev 4 to Rev 5 under Dependencies

* fixed broken link

* Removed Rules Documentation Section

* Removed Implementation Details

* Enclosed manual install instructions in a drop down

* Enclosed manual install instructions in a drop down

* Enclosed container upgrade instructions in a drop down

* Updated NIST OSCAL version in dependencies

* Dual overhaul of the overview and addition of information about validation tooling

* Changed the order of the sections on main readme

* removed out of date information about release of rev 5 guidance

* Some general cleanup

* Cleaning up some things, and adding a table?

* cleaning up pt 2

* cleaning up pt 3

* Picking up from yesterday. Cleaning up wording, adding some drop downs

* added .bash_profile to path information

* changed to OSCAL syntax generaly instead of just SSPs

* Update README.md

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>

* Update README.md

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>

* Update README.md

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>

* cleaning up introduction, implementing AJ's feedback, and adding a portion about visiting the automation website for our documentation

* no need to have a table with different resources if our only resource is the tooling. Correct me if I'm wrong

* this information will all be deprecated soon so no need to explicitly discuss it.

* deleted per AJ's advice

* made this link relative

* deleted per AJ's advice

* fixing typos and awkward wording in the versioning and deprecation section

Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>

* Fixing spacing

Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>

* changed build requirements to latest version of Java, removed Python

---------

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
* fixed error in the OSCAL deprecation strategy section that implied that an oscal version 1.0.0 would not support 1.0.1 +

* updated Rev 4 to Rev 5 under Dependencies

* fixed broken link

* Removed Rules Documentation Section

* Removed Implementation Details

* Enclosed manual install instructions in a drop down

* Enclosed manual install instructions in a drop down

* Enclosed container upgrade instructions in a drop down

* Updated NIST OSCAL version in dependencies

* Dual overhaul of the overview and addition of information about validation tooling

* Changed the order of the sections on main readme

* removed out of date information about release of rev 5 guidance

* Some general cleanup

* Cleaning up some things, and adding a table?

* cleaning up pt 2

* cleaning up pt 3

* Picking up from yesterday. Cleaning up wording, adding some drop downs

* added .bash_profile to path information

* changed to OSCAL syntax generaly instead of just SSPs

* Update README.md

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>

* Update README.md

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>

* Update README.md

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>

* cleaning up introduction, implementing AJ's feedback, and adding a portion about visiting the automation website for our documentation

* no need to have a table with different resources if our only resource is the tooling. Correct me if I'm wrong

* this information will all be deprecated soon so no need to explicitly discuss it.

* deleted per AJ's advice

* made this link relative

* deleted per AJ's advice

* fixing typos and awkward wording in the versioning and deprecation section

Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>

* Fixing spacing

Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>

* changed build requirements to latest version of Java, removed Python

---------

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants