-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
640 readme cleanup #771
640 readme cleanup #771
Conversation
@kyhu65867 thanks for the time today and pushing up the work, I will review once you have finished more of the work and mark it as ready for review from us. 😄 |
I addressed most of issue 640 and some of issue 739. Still in progress but I think it's a significant improvement from where it was before |
I think the main readme is in a good place. I'm going to un-draft this, please let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And a general question, are we going to move the constraint README for development here and delete those files? Is this PR part of a series of such improvements or this going to be the end of this work?
(Sorry, typed this review question, but had not submitted. It's a few hours old.)
I didn't know if we wanted to move the constraints readme just because I wanted this readme to be a general overview of everything this repo has and I think in its final form the repo will have more than just the constraints tooling (unless I'm wrong). I also could see this becoming a series of improvements, especially since there are a bunch of dead readme files scattered throughout the repo. But I think that is a part of a bigger project of "decluttering" so that we can have as streamlined and clear of a readme as possible. It's hard to make a streamlined and clear readme with sort of a clunky repo (no offense) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[deleted my own erroneous review]
I thought I was approving one change, not the whole PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes and recommendations. There is a lot. We can talk through it later if you like.
01836d4
to
b4b6d7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor touchups before a more thorough review. Also it looks like we need to rebase your branch as a bunch of constraint file changes are in the PR now that are not related to the README edits. That happens.
We are very close!
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
…rtion about visiting the automation website for our documentation
… is the tooling. Correct me if I'm wrong
…ction Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
83325f2
to
4fcea59
Compare
* fixed error in the OSCAL deprecation strategy section that implied that an oscal version 1.0.0 would not support 1.0.1 + * updated Rev 4 to Rev 5 under Dependencies * fixed broken link * Removed Rules Documentation Section * Removed Implementation Details * Enclosed manual install instructions in a drop down * Enclosed manual install instructions in a drop down * Enclosed container upgrade instructions in a drop down * Updated NIST OSCAL version in dependencies * Dual overhaul of the overview and addition of information about validation tooling * Changed the order of the sections on main readme * removed out of date information about release of rev 5 guidance * Some general cleanup * Cleaning up some things, and adding a table? * cleaning up pt 2 * cleaning up pt 3 * Picking up from yesterday. Cleaning up wording, adding some drop downs * added .bash_profile to path information * changed to OSCAL syntax generaly instead of just SSPs * Update README.md Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> * Update README.md Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> * Update README.md Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> * cleaning up introduction, implementing AJ's feedback, and adding a portion about visiting the automation website for our documentation * no need to have a table with different resources if our only resource is the tooling. Correct me if I'm wrong * this information will all be deprecated soon so no need to explicitly discuss it. * deleted per AJ's advice * made this link relative * deleted per AJ's advice * fixing typos and awkward wording in the versioning and deprecation section Co-authored-by: A.J. Stein <alexander.stein@gsa.gov> * Fixing spacing Co-authored-by: A.J. Stein <alexander.stein@gsa.gov> * changed build requirements to latest version of Java, removed Python --------- Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
* fixed error in the OSCAL deprecation strategy section that implied that an oscal version 1.0.0 would not support 1.0.1 + * updated Rev 4 to Rev 5 under Dependencies * fixed broken link * Removed Rules Documentation Section * Removed Implementation Details * Enclosed manual install instructions in a drop down * Enclosed manual install instructions in a drop down * Enclosed container upgrade instructions in a drop down * Updated NIST OSCAL version in dependencies * Dual overhaul of the overview and addition of information about validation tooling * Changed the order of the sections on main readme * removed out of date information about release of rev 5 guidance * Some general cleanup * Cleaning up some things, and adding a table? * cleaning up pt 2 * cleaning up pt 3 * Picking up from yesterday. Cleaning up wording, adding some drop downs * added .bash_profile to path information * changed to OSCAL syntax generaly instead of just SSPs * Update README.md Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> * Update README.md Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> * Update README.md Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> * cleaning up introduction, implementing AJ's feedback, and adding a portion about visiting the automation website for our documentation * no need to have a table with different resources if our only resource is the tooling. Correct me if I'm wrong * this information will all be deprecated soon so no need to explicitly discuss it. * deleted per AJ's advice * made this link relative * deleted per AJ's advice * fixing typos and awkward wording in the versioning and deprecation section Co-authored-by: A.J. Stein <alexander.stein@gsa.gov> * Fixing spacing Co-authored-by: A.J. Stein <alexander.stein@gsa.gov> * changed build requirements to latest version of Java, removed Python --------- Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>
Committer Notes
{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.